Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Brave fills in some password on sites, even though I explicitly turned off password management. #10566

Closed
albertjan opened this issue Aug 17, 2017 · 0 comments · Fixed by brave/muon#418

Comments

@albertjan
Copy link

albertjan commented Aug 17, 2017

Test Plan

  1. Save credentials using Brave password manager
  2. Change Password Manager to Don't manage my password
  3. Visit the site for which the credentials were stored
  4. Start typing in user id field, press tab should not auto fill user name
  5. Select the user id auto prompt, should not fill in the saved password

  • Did you search for similar issues before submitting this one?
    Yep 👍

  • Describe the issue you encountered:
    Even though I explicitly turned off password management in brave:

screen shot 2017-08-17 at 20 03 31

I still get:

screen shot 2017-08-17 at 20 03 59

and it doesn't even seem to mind when what the username is as long as it starts as my username as you can see from the image. The password is not correct by the way.

  • Platform (Win7, 8, 10? macOS? Linux distro?):

macOS 10.12.4 (16E195)

  • Brave Version (revision SHA):

36ae2ec

  • Steps to reproduce:
    I doubt it will be easily reproduced somewhere else.

    1. goto github.com also seen on harvestapp.com
    2. start typing username as soon as it starts to autocomplete tab to the password field
    3. dots appear, I don't know whats in there it's not the correct password 😄
  • Actual result:
    A password is filled in

  • Expected result:
    Nothing happens

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  1. Made a new user on this mac,
  2. opened brave,
  3. turned off the password manager,
  4. tried to log into github the first time no autocomplete
  5. restarted brave
  6. autocomplete on github login
  • Is this an issue in the currently released version?
    Yea

  • Can this issue be consistently reproduced?
    On my machine

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@darkdh darkdh self-assigned this Jan 2, 2018
@darkdh darkdh modified the milestones: Triage Backlog, 0.21.x (Developer Channel) Jan 2, 2018
@darkdh darkdh added the security label Jan 2, 2018
@darkdh darkdh modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Jan 9, 2018
@darkdh darkdh modified the milestones: 0.20.x (Beta Channel), 0.21.x (Developer Channel) Jan 9, 2018
@darkdh darkdh modified the milestones: 0.21.x (Developer Channel), 0.19.x Hotfix 12 Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.