Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

onTabMouseMove is called too many times #10689

Closed
NejcZdovc opened this issue Aug 28, 2017 · 3 comments
Closed

onTabMouseMove is called too many times #10689

NejcZdovc opened this issue Aug 28, 2017 · 3 comments
Assignees
@bridiver @NejcZdovc
Labels
feature/tab-preview initiative/perf perf priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Aug 28, 2017 •
edited by luixxiul
Loading

Test plan

#10690 (comment)

Describe the issue you encountered:
Window action onTabMouseMove is called too many times (it's not debounced) when you move mouse inside the tab. Issue is set to the same milestone as #9887
@NejcZdovc NejcZdovc added this to the 0.20.x (Developer Channel) milestone Aug 28, 2017
@NejcZdovc NejcZdovc self-assigned this Aug 28, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 28, 2017
@NejcZdovc
Reduce actions call when doing previews
4197cf8 
Resolves brave#10689

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Aug 28, 2017
Merged
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 28, 2017
@NejcZdovc
Reduce actions call when doing previews
1e362b4 
Resolves brave#10689

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 30, 2017
@NejcZdovc
Reduce actions call when doing previews
17e6945 
Resolves brave#10689

Auditors:

Test Plan:
@bridiver
Copy link
Collaborator

Tab.onMouseMove should be debounced I think, not the action itself

@NejcZdovc
Copy link
Contributor Author

yeah I can move debounce from action inside onMouseMove to the whole onMouseMove

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 18, 2017
@NejcZdovc
Reduce actions call when doing previews
fd4abec 
Resolves brave#10689

Auditors:

Test Plan:
@ghost ghost assigned bridiver Sep 26, 2017
@ghost
Copy link

ghost commented Sep 26, 2017

@bridiver - can we get an update from you on this one.

@ghost ghost added priority/P3 Major loss of function. priority/P2 Crashes. Loss of data. Severe memory leak. and removed priority/P3 Major loss of function. labels Sep 26, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 16, 2017
@NejcZdovc
Reduce actions call when doing previews
2023eb5 
Resolves brave#10689

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Dec 20, 2017
@bsclifton
Merge pull request #10690 from NejcZdovc/hotfix/#10689-preview
b9b4924 
Reduce actions call when doing previews
bsclifton added a commit that referenced this issue Dec 20, 2017
@bsclifton
Merge pull request #10690 from NejcZdovc/hotfix/#10689-preview
30edcdd 
Reduce actions call when doing previews
bsclifton added a commit that referenced this issue Dec 20, 2017
@bsclifton
Merge pull request #10690 from NejcZdovc/hotfix/#10689-preview
9df9566 
Reduce actions call when doing previews
@srirambv srirambv mentioned this issue Dec 27, 2017
Closed
57 tasks
This was referenced Dec 27, 2017
Closed
Closed
This was referenced Jan 2, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jan 9, 2018
Closed
29 tasks
@LaurenWags LaurenWags mentioned this issue Jan 22, 2018
Closed
34 tasks
This was referenced Jan 24, 2018
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Jan 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bridiver bridiver

@NejcZdovc NejcZdovc

Labels
feature/tab-preview initiative/perf perf priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
7 participants
@bridiver @bbondy @luixxiul @bsclifton @NejcZdovc @srirambv @LaurenWags