This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 973
Private tab in its own window causes that window to be white on relaunch (and sometimes unusable) #10768
Labels
Milestone
Comments
If there's only one incognito tab then the window probably shouldn't even re-open right? |
@syuan100 great point 😄 That tab should be removed @LaurenWags what happens to private tabs when there is only one window (which has other tabs)? I'm guessing the private tabs are just removed. I think we'll need to update the logic here to auto-close the window when no more tabs exist |
You are correct @bsclifton - the private tab is just removed from the window with other tabs. |
syuan100
added a commit
to syuan100/browser-laptop
that referenced
this issue
Sep 27, 2017
syuan100
added a commit
to syuan100/browser-laptop
that referenced
this issue
Sep 27, 2017
8 tasks
bsclifton
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
bsclifton
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 20, 2017
luixxiul
added
release-notes/exclude
release-notes/include
and removed
PR/pending-review
release-notes/exclude
labels
Nov 21, 2017
This was referenced Jun 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
#11169 (comment)
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
When a Private tab is in its own window prior to Brave being is closed/relaunched, that window appears all white on relaunch and is in some cases unusable.
Platform (Win7, 8, 10? macOS? Linux distro?):
MacOS, verified on Win by @kjozwiak
Brave Version (revision SHA):
0.18.24
Steps to reproduce:
Actual result:
Window which had the Private tab displays all white (appears dead). You can however type in the URL bar and load a site.
Expected result:
Window should either display what your selection for what 'a new tab shows' or not be there at all since it held a private tab prior to closing Brave.
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Yes, 0.18.23
Can this issue be consistently reproduced?
Yes
Extra QA steps:
Screenshot if needed:
Prior to close:
After relaunch:
The text was updated successfully, but these errors were encountered: