Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

"Save As:" field not scrollable when downloading long filenames #10924

Closed
kjozwiak opened this issue Sep 13, 2017 · 8 comments
Closed

"Save As:" field not scrollable when downloading long filenames #10924

kjozwiak opened this issue Sep 13, 2017 · 8 comments
Assignees
Labels
bug feature/download OS/macOS priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-macOS QA/test-plan-specified release-notes/include

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Sep 13, 2017

- Did you search for similar issues before submitting this one?

Yes

- Describe the issue you encountered:

Filenames under the "Save As:" field when downloading a file are not scrollable. When a filename is longer than the default width, users won't be able to scroll through the entire filename.

- Platform (Win7, 8, 10? macOS? Linux distro?):

macOS 10.12.6 x64 - Reproduced

- Brave Version (revision SHA):

Brave: 0.18.29
rev: 85f059d
Muon: 4.3.16
libchromiumcontent: 60.0.3112.113

Brave: 0.18.32
rev: e94738d
Muon: 4.3.18
libchromiumcontent: 61.0.3163.71

- Test plan / Steps to reproduce:

  1. Open Brave and visit https://www.deviantart.com/art/Dark-and-Day-Al-Jebra-208669006
  2. Right click on the image and select "Save Image"
  3. Attempt to scroll through the filename in the "Save As:" field

- Actual result:

The filename text under "Save As:" field isn't currently scrollable.

- Expected result:

The filename text under the "Save As:" field should be scrollable. User should be able to scroll through the entire filename that's being displayed.

- Will the steps above reproduce in a fresh profile? If not what other info can be added?

Yes

- Is this an issue in the currently released version?

Yes

- Can this issue be consistently reproduced?

Yes

- Screenshot if needed:

downloadscroll

@kjozwiak kjozwiak added this to the 0.20.x (Developer Channel) milestone Sep 13, 2017
@NejcZdovc
Copy link
Contributor

@kjozwiak was this working before 0.18.x?

@kjozwiak
Copy link
Member Author

@kjozwiak was this working before 0.18.x?

Looks like the issue has been in Brave for sometime now. I went through the following builds and could still reproduce the original issue mentioned above using the same STR:

  • Brave: 0.18.29 rev: 85f059d - Reproduced
  • Brave: 0.18.23 rev: 36ae2ec - Reproduced
  • Brave: 0.18.14 rev: ad92d02 - Reproduced
  • Brave: 0.17.19 rev: 4e46480 - Reproduced

I checked Chrome 60.0.3112.113 and it looks like it's working there.

@kjozwiak kjozwiak modified the milestones: 0.20.x (Developer Channel), 0.21.x (Nightly Channel) Sep 13, 2017
@alexwykoff alexwykoff added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 19, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@bbondy bbondy modified the milestones: Triage Backlog, Prioritized Backlog Nov 2, 2017
@cndouglas
Copy link

Related: #12628

@cndouglas
Copy link

May be fixed by #11906 in 0.21.0, but I have not tested yet.

@cndouglas
Copy link

I have confirmed this was fixed by #11906 in 0.21.x.

@bsclifton
Copy link
Member

@liunkae awesome! thanks for testing 😄 I'll close / mark milestone as 0.21.x

@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.21.x (Beta Channel) Feb 19, 2018
@darkdh darkdh modified the milestones: 0.22.x (Developer Channel), 0.21.x w/ Chromium 65 (Beta Channel) Mar 1, 2018
@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@LaurenWags
Copy link
Member

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/download OS/macOS priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-macOS QA/test-plan-specified release-notes/include
Projects
None yet
Development

No branches or pull requests

8 participants