Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Save Page as dialog broken on macOS #12628

Closed
cndouglas opened this issue Jan 12, 2018 · 7 comments
Closed

Save Page as dialog broken on macOS #12628

cndouglas opened this issue Jan 12, 2018 · 7 comments

Comments

@cndouglas
Copy link

Description

When trying to save a page on macOS, the save as dialog box does not expand properly.

Steps to Reproduce

  1. Open Brave and navigate to any webpage.
  2. Select File > Save Page as
  3. Press the expansion arrow button:

Actual result:
The dialog box is not expanded properly. See the screen recording below:

Expected result:
The dialog box should be expanded properly.

Reproduces how often:
Always.

Brave Version

about:brave info:
Brave: 0.19.131
rev: da2f347
Muon: 4.5.36
libchromiumcontent: 63.0.3239.132
V8: 6.3.292.49
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 17.3.0
OS Architecture: x64

Reproducible on current live release:
Yes, 0.19.131

Additional Information

Related: #10924

@cndouglas
Copy link
Author

May be fixed by #11906 in 0.21.0, but I have not tested yet.

@humphd
Copy link

humphd commented Feb 16, 2018

I'm not able to reproduce this on master (9c4159a) on macOS 10.13.3.

@cndouglas
Copy link
Author

@humphd Thanks! I have confirmed that this is fixed in the latest 0.21.x beta build (0.21.9).

Someone please close this, tag with the 0.21.x milestone, and add the release-notes/include label.

@cndouglas
Copy link
Author

@bsclifton Could we include this in the 0.21.x milestone? Thanks.

@bsclifton bsclifton added this to the 0.21.x (Beta Channel) milestone Feb 17, 2018
@bsclifton
Copy link
Member

@liunkae done- thanks for calling this out 😄 (fixed by @darkdh)

@bsclifton
Copy link
Member

Moving to 0.22.x; we're going to have 0.21.x-C65 only contain the Chromium upgrade 😄 👍

@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Beta Channel), 0.22.x (Developer Channel) Mar 9, 2018
@LaurenWags
Copy link
Member

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants