Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Update siteInfo.js to our BEM style #10932

Closed
luixxiul opened this issue Sep 13, 2017 · 0 comments
Closed

Update siteInfo.js to our BEM style #10932

luixxiul opened this issue Sep 13, 2017 · 0 comments
Assignees
@luixxiul
Labels
priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 13, 2017 •
edited
Loading

Test plan

#10933 (comment)

Describe the issue you encountered: Update siteInfo.js to the modified BEM style (ref: https://github.com/brave/browser-laptop/blob/master/docs/style.md#defining-our-blocks-elements-and-modifiers).

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:
@luixxiul luixxiul self-assigned this Sep 13, 2017
@luixxiul luixxiul mentioned this issue Sep 13, 2017
Merged
8 tasks
@luixxiul luixxiul added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 13, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 13, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@syuan100
Update siteInfo.js to the modified BEM style
725803d 
Closes brave#10932

Auditors:

Test Plan:
1. Open https://mixed-script.badssl.com/
2. Open https://mixed.badssl.com/ in a new tab
3. Open http://http.badssl.com/ in a new tab
4. Click the lock icon of each tab
5. Make sure the site info dialogs are properly displayed
This was referenced Dec 20, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @srirambv @LaurenWags