Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Moving tabs sometimes doesn't respect the correct position #10961

Closed
bbondy opened this issue Sep 14, 2017 · 0 comments
Closed

Moving tabs sometimes doesn't respect the correct position #10961

bbondy opened this issue Sep 14, 2017 · 0 comments

Comments

@bbondy
Copy link
Member

bbondy commented Sep 14, 2017

Test plan

See below


  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    After closing some tabs in a window, sometimes dropping a tab at a specific spot will move the tab to a different spot. Often 2 to the left.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS, but probably all

  • Brave Version (revision SHA):
    0.18.29

  • Steps to reproduce:

    1. Open 7 tabs
    2. Close the middle 2
    3. Move the first tab to another position
  • Actual result:
    Sometimes the drop position isn't consistent with where the tab gets moved to

  • Expected result:
    The tab should be moved where it was dropped

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes but it seems harder.

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Not 100% but if you play with it for a couple minutes you'll get it, it seems somewhat related to tab close.

@bbondy bbondy added this to the 0.19.x (Beta Channel) milestone Sep 14, 2017
@bbondy bbondy self-assigned this Sep 14, 2017
bbondy added a commit that referenced this issue Sep 18, 2017
Tab move no longer allows controlling of the frame index

Fix #10961
bbondy added a commit that referenced this issue Sep 18, 2017
Tab move no longer allows controlling of the frame index

Fix #10961
bbondy added a commit that referenced this issue Sep 18, 2017
Tab move no longer allows controlling of the frame index

Fix #10961
@bbondy bbondy closed this as completed in 49426f2 Sep 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.