Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow adblock checking within the same origin #11004

Closed
bbondy opened this issue Sep 19, 2017 · 2 comments
Closed

Allow adblock checking within the same origin #11004

bbondy opened this issue Sep 19, 2017 · 2 comments
Assignees
@bbondy
Labels
QA/no-qa-needed release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@bbondy
Copy link
Member

bbondy commented Sep 19, 2017

Currently we only do same origin adblock checks for a couple websites. We should be doing it for all sites for the best blocking results.
@bbondy bbondy added this to the 0.20.x (Developer Channel) milestone Sep 19, 2017
@bbondy bbondy self-assigned this Sep 19, 2017
bbondy added a commit that referenced this issue Sep 19, 2017
@bbondy
Allow adblock checking within the same origin
b33835f 
Fix #11004
@bbondy bbondy mentioned this issue Sep 19, 2017
Merged
8 tasks
bbondy added a commit that referenced this issue Sep 19, 2017
@bbondy
Allow adblock checking within the same origin
f46866b 
Fix #11004
@luixxiul luixxiul added needs-info Another team member needs information from the PR/issue opener. release-notes/include labels Sep 19, 2017
@luixxiul
Copy link
Contributor

no-qa-needed?

bbondy added a commit that referenced this issue Sep 20, 2017
@bbondy
Allow adblock checking within the same origin
9cd18a2 
Fix #11004
@bbondy bbondy modified the milestones: 0.20.x (Developer Channel), 0.19.x (Beta Channel) Sep 20, 2017
@bbondy bbondy removed the needs-info Another team member needs information from the PR/issue opener. label Sep 20, 2017
@bbondy
Copy link
Member Author

bbondy commented Sep 20, 2017

Pulling this into 0.19.x and we'll back out if we see problems.

@luixxiul I just need everyone to be on the lookout for sites that break that didn't used to. But there's no specific test case needed from QA.

@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
QA/no-qa-needed release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
2 participants
@bbondy @luixxiul