Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Ledger refactoring #11009

Closed
NejcZdovc opened this issue Sep 19, 2017 · 1 comment
Closed

Ledger refactoring #11009

NejcZdovc opened this issue Sep 19, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
feature/rewards project-tracking QA/no-qa-needed refactoring release-notes/include
Milestone
0.19.x (Beta Chan...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 19, 2017 •
edited
Loading

Description

This is a tracking issue for ledger refactoring.

Phase I #11209

In this phase we will introduce state into the ledger. Everything should be handled with appState now and events should be transmitted via reducers.
NOTE This refactor will not have working add founds. This is because we will do complete rewrite of this dialog in next phases

QA first pass:
#11214
#11217

MacOS: #11037 (comment)
Windows: #11037 (comment)

Phase || #10945

In this phase we will add support for bat libraries. We will also remove all add found related code that will not be used anymore.

Phase ||| #11193

In this phase we will add add found wizard back to the ledger. After this phase ledger should be fully functional again.

Phase IV #11210

In the last phase we will do some cleanup and optimisations that were wound while refactoring. We will also add remanning tests so that coverage will be as good as possible.
@NejcZdovc NejcZdovc added this to the 0.19.x (Beta Channel) milestone Sep 19, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 19, 2017
@NejcZdovc NejcZdovc added the Epic label Sep 19, 2017
@NejcZdovc NejcZdovc mentioned this issue Sep 20, 2017
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 20, 2017
@NejcZdovc
Moves eventStore into appStore
d951682 
Resolves brave#11009

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 20, 2017
Merged
27 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 20, 2017
@NejcZdovc
Moves eventStore into appStore
449cc52 
Resolves brave#11009

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 20, 2017
@NejcZdovc
Moves eventStore into appStore
84b4913 
Resolves brave#11009

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 20, 2017
@NejcZdovc
Moves eventStore into appStore
30004b6 
Resolves brave#11009

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 21, 2017
@NejcZdovc
Moves eventStore into appStore
ef0318a 
Resolves brave#11009

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 22, 2017
@NejcZdovc
Moves eventStore into appStore
96cc08a 
Resolves brave#11009

Auditors:

Test Plan:
@luixxiul luixxiul mentioned this issue Sep 23, 2017
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 26, 2017
@NejcZdovc
Moves eventStore into appStore
77f4c8a 
Resolves brave#11009

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Sep 26, 2017
Closed
8 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 26, 2017
@NejcZdovc
Moves eventStore into appStore
0f38001 
Resolves brave#11009

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Sep 29, 2017
@NejcZdovc
Moves eventStore into appStore
80fc7c4 
Resolves brave#11009

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 2, 2017
@NejcZdovc
Moves eventStore into appStore
e8436ec 
Resolves brave#11009

Auditors:

Test Plan:
NejcZdovc added a commit that referenced this issue Oct 3, 2017
@NejcZdovc
Merge pull request #11037 from NejcZdovc/refactor/#11009-ledger
de5f381 
Ledger refactoring
NejcZdovc added a commit that referenced this issue Oct 3, 2017
@NejcZdovc
Merge pull request #11037 from NejcZdovc/refactor/#11009-ledger
dddbcee 
Ledger refactoring
NejcZdovc added a commit that referenced this issue Oct 3, 2017
@NejcZdovc
Merge pull request #11037 from NejcZdovc/refactor/#11009-ledger
38c63b0 
Ledger refactoring
@NejcZdovc NejcZdovc reopened this Oct 3, 2017
@bsclifton
Copy link
Member

Closing this issue- we've got everything merged and the rest of the work is captured in #11210, which is in 0.19.x release 2

@kjozwiak kjozwiak mentioned this issue Oct 12, 2017
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Moves eventStore into appStore
562ed05 
Resolves brave#11009
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards project-tracking QA/no-qa-needed refactoring release-notes/include
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
3 participants
@luixxiul @bsclifton @NejcZdovc