Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autoplay notification bar not shown when set to "always ask" #11042

Closed
srirambv opened this issue Sep 20, 2017 · 11 comments
Closed

Autoplay notification bar not shown when set to "always ask" #11042

srirambv opened this issue Sep 20, 2017 · 11 comments

Comments

@srirambv
Copy link
Collaborator

Description

Steps to Reproduce

  1. Set auto media play to always ask
  2. Visit https://vimeo.com/215927968
  3. Click play, No notification bar for auto play is shown, media starts play.

Actual result:

Notification bars not shown

Expected result:
Should show notification bar for auto play media

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

Brave 0.19.7
rev c8481a9
Muon 4.4.16

Additional Information

#11036
@LaurenWags to confirm for macOS

@luixxiul
Copy link
Contributor

luixxiul commented Sep 20, 2017

You'll need to visit https://vimeo.com at first to display the notification bar, though I'm not sure that is intentional.

@LaurenWags
Copy link
Member

Reproduced on MacOS.

@bbondy
Copy link
Member

bbondy commented Sep 20, 2017

I think it's just because this wasn't in the build, please do per OS testing on the next build:
#10864

@LaurenWags
Copy link
Member

still seeing issue as described, requested @kjozwiak to check.

@LaurenWags
Copy link
Member

LaurenWags commented Sep 28, 2017

still see this issue on 0.19.23 in MacOS
11042

@srirambv
Copy link
Collaborator Author

Works fine on Windows
autoplay

@bsclifton
Copy link
Member

Works for me as expected...

@LaurenWags, in your screenshot you're clicking play (which would override the video setting). Do you have an exception in place for vimeo.com? If not, does the autoplay alert show if you force a reload with Cmd + R?

@LaurenWags
Copy link
Member

@bsclifton I do not have an exception in place for vimeo.com. Here's a quick gif of what I did and I included the cmd+R - still no notification. I clicked play at the end.

I will note, that if i just visit vimeo.com, I do get the notification asking 'Allow https://vimeo.com to autoplay media?', but not on the video specified in the issue.

11042-cmt

@bsclifton bsclifton changed the title Notification bars not shown Autoplay notification bar not shown when set to "always ask" Oct 2, 2017
@bsclifton
Copy link
Member

@LaurenWags I can repro now- for some reason, my profile had shields down on vimeo.com. When I enabled them again, I no longer get the notification

@bsclifton
Copy link
Member

This may be related: #11069

Because this feature appears to be related to shields, I'm going to remove the release-blocking tag and also the milestone from this issue

@darkdh
Copy link
Member

darkdh commented Dec 1, 2017

Vemeo will not autoplay if you directly navigate to it through url. (you can try other browsers as parity check)
It will only autoplay from search result (ex. google search)
So in this case, user initiated playing video doesn't count as autoplay

@darkdh darkdh closed this as completed Dec 1, 2017
@darkdh darkdh removed this from the Triage Backlog milestone Dec 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants