This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Brave not asking for permissions when loading geolocations #10864
Milestone
Comments
|
Still an issue with the latest preview build:
Platforms checked:
|
bridiver
added a commit
to brave/muon
that referenced
this issue
Sep 11, 2017
8 tasks
bridiver
added a commit
to brave/muon
that referenced
this issue
Sep 11, 2017
NejcZdovc
pushed a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Sep 13, 2017
fix brave#10864 requires muon 4.3.19+
8 tasks
bbondy
added a commit
that referenced
this issue
Sep 13, 2017
This addresses review feedback for #10864
bbondy
added a commit
that referenced
this issue
Sep 13, 2017
This addresses review feedback for #10864
NejcZdovc
pushed a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Sep 13, 2017
This addresses review feedback for brave#10864
bbondy
added a commit
to brave/muon
that referenced
this issue
Sep 13, 2017
It was introduced with brave/browser-laptop#10864 Auditors: @bridiver
bbondy
added a commit
to brave/muon
that referenced
this issue
Sep 13, 2017
It was introduced with brave/browser-laptop#10864 Auditors: @bridiver
|
This is all merged above for 4.3.21 and 0.18.x so marking this as complete. |
This was referenced Sep 14, 2017
bbondy
added a commit
to brave/muon
that referenced
this issue
Sep 14, 2017
It was introduced with brave/browser-laptop#10864 Auditors: @bridiver
bridiver
pushed a commit
to brave/muon
that referenced
this issue
Sep 20, 2017
It was introduced with brave/browser-laptop#10864 Auditors: @bridiver
|
Was the fix merged to 0.19? For me the geolocation issue on https://developer.mozilla.org/en-US/docs/Web/API/Geolocation/Using_geolocation is reproduced on: Brave: 0.19.7 |
|
This was not merged into 0.19.x yet, see #10896 |
bbondy
modified the milestones:
0.18.x Hotfix 2 (Release Channel),
0.19.x (Beta Channel)
bridiver
added a commit
to brave/muon
that referenced
this issue
Oct 4, 2017
bridiver
pushed a commit
to brave/muon
that referenced
this issue
Oct 4, 2017
It was introduced with brave/browser-laptop#10864 Auditors: @bridiver
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
fix brave#10864 requires muon 4.3.19+
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
This addresses review feedback for brave#10864
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
load https://browserleaks.com/geo within Brave
- Did you search for similar issues before submitting this one?
Yes
- Describe the issue you encountered:
Geolocation data is being loaded without prompting the user for permission.
- Platform (Win7, 8, 10? macOS? Linux distro?):
Win 7 x86 - Reproduced
Win 10 x64 - Reproduced
macOS 10.12.6 - Reproduced
- Brave Version (revision SHA):
Brave: 0.18.31
rev: a5a7280
Muon: 4.3.17
libchromiumcontent: 61.0.3163.71
- Steps to reproduce:
You'll notice that the geolocation data will load without asking for the required permissions.
- Actual result:
Users geolocation data loads without asking the user for the required permissions.
- Expected result:
Brave should be prompting the user for permission before loading geolocation data.
- Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
- Is this an issue in the currently released version?
No. Looks like it's a new regression in
0.18.31- Can this issue be consistently reproduced?
Yes
- Screenshot if needed:
The text was updated successfully, but these errors were encountered: