Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Errors joining a session on https://www.scrumpoker.online/ #11053

Closed
bsclifton opened this issue Sep 20, 2017 · 9 comments
Closed

Errors joining a session on https://www.scrumpoker.online/ #11053

bsclifton opened this issue Sep 20, 2017 · 9 comments

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 20, 2017

Description

There are JavaScript errors when loading:
https://www.scrumpoker.online/

angular.js:38 Uncaught Error: [$injector:modulerr] http://errors.angularjs.org/1.6.4/$injector/modulerr?p0=scrum-online&p1=Error%3A%20%5B%24injector%3Amodulerr%5D%20http%3A%2F%2Ferrors.angularjs.org%2F1.6.4%2F%24injector%2Fmodulerr%3Fp0%3Dangular-google-analytics%26p1%3DError%253A%2520%255B%2524injector%253Anomod%255D%2520http%253A%252F%252Ferrors.angularjs.org%252F1.6.4%252F%2524injector%252Fnomod%253Fp0%253Dangular-google-analytics%250A%2520%2520%2520%2520at%2520https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A6%253A425%250A%2520%2520%2520%2520at%2520https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A26%253A270%250A%2520%2520%2520%2520at%2520b%2520(https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A25%253A299)%250A%2520%2520%2520%2520at%2520https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A26%253A44%250A%2520%2520%2520%2520at%2520https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A42%253A117%250A%2520%2520%2520%2520at%2520q%2520(https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A7%253A495)%250A%2520%2520%2520%2520at%2520g%2520(https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A41%253A476)%250A%2520%2520%2520%2520at%2520https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A42%253A149%250A%2520%2520%2520%2520at%2520q%2520(https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A7%253A495)%250A%2520%2520%2520%2520at%2520g%2520(https%253A%252F%252Fajax.googleapis.com%252Fajax%252Flibs%252Fangularjs%252F1.6.4%252Fangular.min.js%253A41%253A476)%0A%20%20%20%20at%20https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A6%3A425%0A%20%20%20%20at%20https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A42%3A407%0A%20%20%20%20at%20q%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A7%3A495)%0A%20%20%20%20at%20g%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A41%3A476)%0A%20%20%20%20at%20https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A42%3A149%0A%20%20%20%20at%20q%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A7%3A495)%0A%20%20%20%20at%20g%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A41%3A476)%0A%20%20%20%20at%20eb%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A46%3A44)%0A%20%20%20%20at%20c%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A21%3A373)%0A%20%20%20%20at%20Sc%20(https%3A%2F%2Fajax.googleapis.com%2Fajax%2Flibs%2Fangularjs%2F1.6.4%2Fangular.min.js%3A22%3A179)
    at angular.js:38
    at angular.js:4920
    at q (angular.js:403)
    at g (angular.js:4880)
    at eb (angular.js:4802)
    at c (angular.js:1914)
    at Sc (angular.js:1935)
    at ue (angular.js:1820)
    at HTMLDocument.<anonymous> (angular.js:33367)
    at i (jquery.min.js:2)

Steps to Reproduce

  1. Visit https://www.scrumpoker.online/ in Brave with shields up
  2. Notice the "cards" drop down is empty. Also clicking "Create" does nothing
  3. Turn shields off
  4. Notice "cards" drop down is populated. Clicking "Create" also works

Brave Version

about:brave info:

Brave: 0.19.9
rev: 2a9a56f
Muon: 4.4.19
libchromiumcontent: 61.0.3163.79
V8: 6.1.534.32
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:
No - works great on current release (0.18.36)

@bbondy
Copy link
Member

bbondy commented Sep 20, 2017

This matches rule -google-analytics.$third-party and the site is also broken on uBlock and ABP. I'll add an exception rule in our list.

@srirambv
Copy link
Collaborator

srirambv commented Sep 27, 2017

Still an issue on 0.19.20
image

@srirambv srirambv reopened this Sep 27, 2017
@bsclifton
Copy link
Member Author

@bbondy unfortunately, the rules didn't seem to fix the issue 😦

@bsclifton bsclifton removed this from the 0.19.x (Beta Channel) milestone Sep 27, 2017
@kjozwiak
Copy link
Member

Yup, confirmed under macOS 10.12.6 x64 and Ubuntu 17.04 x64 using the following build:

Brave: 0.19.20 rev: d9566ab
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100

@luixxiul
Copy link
Contributor

Is it the issue of the rule or the rule intepreter? See: https://community.brave.com/t/filters-for-iran/8199/3?u=suguru

@bbondy bbondy self-assigned this Oct 7, 2017
@bbondy bbondy added this to the 0.19.x (Beta Channel) milestone Oct 7, 2017
@bbondy
Copy link
Member

bbondy commented Oct 7, 2017

Fixed here:
brave-experiments/ad-block@4360345

@Toxantron
Copy link

As the author and maintainer - anything I can do to help such problems in the future?

@bsclifton
Copy link
Member Author

@Toxantron no action needed- we just had to update an ad-block rule and Brave users are back in business 😄 Thanks for checking in (love the tool!)

@Toxantron
Copy link

I am glad to hear. Will keep working on it once I finish my thesis. ;-)

nightsky108 pushed a commit to nightsky108/adblock-lists that referenced this issue Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.