This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
URL suggestions for simple domain names sometimes don't appear up top #11057
Assignees
Labels
Milestone
Comments
bbondy
added a commit
that referenced
this issue
Sep 21, 2017
Fix #11057 Since this has to do with muon url parsing libraries it needed a test inside the muon test as well. But muon tests are only in master, so I included that test only in master. This was introduced when we switched URL parsing libraries because now parsed URL attributes are not null but instead an empty string.
bbondy
added a commit
that referenced
this issue
Sep 21, 2017
Fix #11057 Since this has to do with muon url parsing libraries it needed a test inside the muon test as well. But muon tests are only in master, so I included that test only in master. This was introduced when we switched URL parsing libraries because now parsed URL attributes are not null but instead an empty string.
|
cc @bsclifton forgot to mark auditor please check out e015e62 |
|
++ |
This was referenced Sep 21, 2017
|
@bbondy asked a user who was also experiencing this issue ( @tbates) to check this out and he provided some feedback here: #6537 (comment). Wondering if you could review? I'm thinking they might need to be logged separately instead of trying to resolve with this issue. |
This was referenced Sep 25, 2017
This was referenced Sep 26, 2017
This was referenced Sep 27, 2017
|
@LaurenWags I don't think those are related to this. You'll have to please create new issues, 1 for each individual thing and then actual results vs expected results. Easiest with a fresh profile so that the use case can be reproduced. |
syuan100
pushed a commit
to syuan100/browser-laptop
that referenced
this issue
Nov 9, 2017
Fix brave#11057 Since this has to do with muon url parsing libraries it needed a test inside the muon test as well This was introduced when we switched URL parsing libraries because now parsed URL attributes are not null but instead an empty string.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Sometimes typing a site like twitter.com will result in a first suggestion of a longer URL instead of just matching to twitter.com
Steps to Reproduce
Pre-req you must have URLs that are frequently visited with a high count
twiActual result:
Matches to twitter.com/i/notifications
Expected result:
Matches to twitter.com
Brave Version
about:brave info:
0.18.36
Reproducible on current live release:
Yes
Additional Information
This was introduced when we switched URL parsing libraries because now parsed URL attributes are not null but instead an empty string.
The text was updated successfully, but these errors were encountered: