Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

notification bar not appearing on mailto: link command+click #11075

Closed
diracdeltas opened this issue Sep 21, 2017 · 3 comments
Closed

notification bar not appearing on mailto: link command+click #11075

diracdeltas opened this issue Sep 21, 2017 · 3 comments
Labels
bug feature/notificationbar priority/P4 Minor loss of function. Workaround usually present. regression wontfix

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Sep 21, 2017

found while testing #4198 (comment)

STR:

  1. make sure you have an external application set as your default mail handler
  2. go to brave.com and cmd+click any of the mailto: links at the bottom to open in a new tab
  3. the new tab does not show the notification bar (it seems to load forever) whereas previously it did

the notification bar does appear if you click on the mailto: link (instead of cmd+click) so this may not be an issue with the notification bar itself

@bbondy
Copy link
Member

bbondy commented Sep 22, 2017

I don't think this is a bug.

We only ever prompted for this for external applications.
If you have brave as your default handler it just goes to it, always has for us.

screen shot 2017-09-21 at 8 32 28 pm

@bbondy
Copy link
Member

bbondy commented Sep 22, 2017

Verified the default handler link is also present. I'm going to remove this from the milestone, but I think it should be closed. But let me know if I'm not understanding what the regression is and if it should go back in.

@bbondy bbondy modified the milestone: 0.19.x (Beta Channel) Sep 22, 2017
@bbondy bbondy changed the title notification bar not appearing on mailto: link click notification bar not appearing on mailto: link command+click Sep 25, 2017
@bbondy bbondy removed this from the 0.19.x (Beta Channel) milestone Sep 25, 2017
@bbondy
Copy link
Member

bbondy commented Sep 25, 2017

Removing from milestone since this is only with command+click and I think it's a subset of an existing bug with command+click (for safe browsing was it?) anyway let me know if that's a problem.

@bsclifton bsclifton added the priority/P4 Minor loss of function. Workaround usually present. label Oct 9, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), Triage Backlog Sep 18, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug feature/notificationbar priority/P4 Minor loss of function. Workaround usually present. regression wontfix
Projects
None yet
Development

No branches or pull requests

4 participants