mailto: notifications display "null" rather than the domain when opening in new tabs #4198
Comments
|
@Sh1d0w could you re-verify this with master tip? I can't reproduce? If you can still reproduce please let me know the page and link that you can reproduce from. Thanks! |
|
@bbondy Hey Brian. Yes it happens on the latest master. I think it can be Linux issue only, currently don't have Mac or Win PC to confirm that, but it happens under Linux. The steps to reproduce are the same as stated in the issue. |
|
@bbondy Since update to version 0.12.4 now this message appears even if I try to open a magnet torrent link:
|
kjozwiak
changed the title
|
I ran into this issue while helping a community memeber. I noticed that rather than the correct domain appearing under the notification, "Null" was being displayed. This happens when a website uses STR:
Reproduced with the latest build of Brave:
Reproducible on the following platforms:
@diracdeltas, could you please take a look? |
in the permission notification bar fix #4198 Test Plan: 1. go to brave.com 2. scroll down to the contact section 4. right click on one of the email addresses to open in a new tab 5. the notification bar should say, 'Allow Brave Browser to open an external application?'
in the permission notification bar fix #4198 Test Plan: 1. go to brave.com 2. scroll down to the contact section 4. right click on one of the email addresses to open in a new tab 5. the notification bar should say, 'Allow Brave Browser to open an external application?'
in the permission notification bar fix #4198 Test Plan: 1. go to brave.com 2. scroll down to the contact section 4. right click on one of the email addresses to open in a new tab 5. the notification bar should say, 'Allow Brave Browser to open an external application?'
|
No notification on Windows |
|
I see the same as @srirambv on MacOS. |
|
The notification not appearing at all seems to be a separate issue. This change only changes the name of the domain in the notification. |
|
^ opened #11075 |
Test plan
#10668 (comment)
Did you search for similar issues before submitting this one?
No
Describe the issue you encountered:
Clicking mailto link produces the following message:
Allow null to open an external application?
- Brave Version: 0.12.1 - Steps to reproduce: 1. Open brave.com 2. Go to footer section 3. Click Support link in the footer - Screenshot if needed: - Any related issues: #4003The text was updated successfully, but these errors were encountered: