Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

JavaScript error in browser process when typing in URL bar #11128

Closed
bsclifton opened this issue Sep 25, 2017 · 1 comment
Closed

JavaScript error in browser process when typing in URL bar #11128

bsclifton opened this issue Sep 25, 2017 · 1 comment
Assignees
@bsclifton
Labels
automated-tests bug QA/no-qa-needed release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 25, 2017 •
edited
Loading

Test plan

npm run unittest -- --grep="APP_URL_BAR_SUGGESTIONS_CHANGED"

Description

JavaScript error in browser process when typing in URL bar
image

Steps to Reproduce

Discovered by @srirambv, but clear STR unknown

Actual result:

Expected result:

Reproduces how often:
?

Brave Version

about:brave info:
Brave: 0.19.15
rev: 19b48f3
Muon: 4.4.19
libchromiumcontent: 61.0.3163.79
V8: 6.1.534.32
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:
No

Additional Information
@bsclifton bsclifton added the bug label Sep 25, 2017
@bsclifton bsclifton added this to the 0.19.x (Beta Channel) milestone Sep 25, 2017
@bsclifton bsclifton self-assigned this Sep 25, 2017
bsclifton added a commit that referenced this issue Sep 25, 2017
@bsclifton
Put extra checks in place for URL bar suggestions (to avoid function …
3cdaafc 
…call on undefined)

Fixes #11128

Auditors: @srirambv

Test Plan:
`npm run unittest -- --grep="APP_URL_BAR_SUGGESTIONS_CHANGED"`
bsclifton added a commit that referenced this issue Sep 25, 2017
@bsclifton
Put extra checks in place for URL bar suggestions (to avoid function …
7131ed9 
…call on undefined)

Fixes #11128

Auditors: @srirambv

Test Plan:
`npm run unittest -- --grep="APP_URL_BAR_SUGGESTIONS_CHANGED"`
@bsclifton
Copy link
Member Author

master 2513065
0.20.x 3cdaafc
0.19.x 7131ed9

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bsclifton @syuan100
Put extra checks in place for URL bar suggestions (to avoid function …
faa4054 
…call on undefined)

Fixes brave#11128

Auditors: @srirambv

Test Plan:
`npm run unittest -- --grep="APP_URL_BAR_SUGGESTIONS_CHANGED"`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
automated-tests bug QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
1 participant
@bsclifton