Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Manually entered value is not retained for publisher #11238

Closed
srirambv opened this issue Oct 2, 2017 · 6 comments
Closed

Manually entered value is not retained for publisher #11238

srirambv opened this issue Oct 2, 2017 · 6 comments
Assignees
@NejcZdovc
Labels
0.21.x issue first seen in 0.21.x feature/rewards product/user-happiness QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Milestone
0.21.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 2, 2017

Description

Manually entered value is not retained for publisher

Steps to Reproduce

  1. Build from ad111f2 and create a clean profile
  2. Visit couple of sites to add to list and pin all of them
  3. Manually change one of the site % to 3, doesnt retain the entered value, instead recalculates the % for all pinned publishers

Actual result:

ledgerrefactor

Expected result:
manually entered value should be retained and other pinned publisher values should be recalculated
to bring to 100%

Reproduces how often: [What percentage of the time does it reproduce?]
consisten

Brave Version

about:brave info:

Brave 0.21.0
V8 6.1.534.41
rev 233dae1
Muon 4.4.25

Reproducible on current live release:

No, retains value entered

Additional Information
@NejcZdovc NejcZdovc mentioned this issue Oct 2, 2017
Merged
27 tasks
@NejcZdovc
Copy link
Contributor

this is not a bug, it's designed like this. We only retain value when pinned publisher sum is over 100%. Changing this to the suggestion

@NejcZdovc NejcZdovc added suggestion and removed bug labels Oct 9, 2017
@NejcZdovc NejcZdovc removed their assignment Oct 9, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Oct 9, 2017 •
edited
Loading

we could display a tooltip / warning which says "please make the sum more that 100%". Obviously we do not want to see that modifying one value of a bunch of sites changes every favorite site's value. We also cannot redo anything on that table, including deleting sites (see #11164 #4634 (comment)) and I suspect that is what @srirambv concerns.

@NejcZdovc
Copy link
Contributor

Agree that we can improve this functionality, the only thing that I am saying is that this is not a bug

@cezaraugusto cezaraugusto added this to the Triage Backlog milestone Nov 8, 2017
This was referenced Nov 16, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Jan 2, 2018
Closed
@NejcZdovc
Copy link
Contributor

+1 from https://www.reddit.com/r/BATProject/comments/7sc5qp/trying_to_adjust_payment_percent_seems_to_be/

@NejcZdovc NejcZdovc self-assigned this Jan 23, 2018
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.20.x Hotfix 3 (Ledger improvments) Feb 5, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 5, 2018
@NejcZdovc
Fixes pinned values when total is not over 100
ac59a52 
Resolves brave#11238

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 5, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 6, 2018
@NejcZdovc
Fixes pinned values when total is not over 100
6b9b8eb 
Resolves brave#11238

Auditors:

Test Plan:
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 13, 2018
@NejcZdovc
Fixes pinned values when total is not over 100
997669a 
Resolves brave#11238

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 16, 2018
@bsclifton
Merge pull request #13020 from NejcZdovc/feature/#11238-manual
1fa3d0d 
Fixes pinned values when total is not over 100
bsclifton added a commit that referenced this issue Feb 16, 2018
@bsclifton
Merge pull request #13020 from NejcZdovc/feature/#11238-manual
6174b54 
Fixes pinned values when total is not over 100
bsclifton added a commit that referenced this issue Feb 16, 2018
@bsclifton
Merge pull request #13020 from NejcZdovc/feature/#11238-manual
da68356 
Fixes pinned values when total is not over 100
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc pushed a commit that referenced this issue Feb 24, 2018
@bsclifton @NejcZdovc
Merge pull request #13020 from NejcZdovc/feature/#11238-manual
1801b9b 
Fixes pinned values when total is not over 100
@LaurenWags
Copy link
Member

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

ryanml pushed a commit to ryanml/browser-laptop that referenced this issue Feb 27, 2018
@NejcZdovc @ryanml
Fixes pinned values when total is not over 100
425da0a 
Resolves brave#11238

Auditors:

Test Plan:
@srirambv
Copy link
Collaborator Author

Verified on 0.21.16

@srirambv srirambv added the 0.21.x issue first seen in 0.21.x label Feb 27, 2018
This was referenced Feb 27, 2018
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Mar 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
0.21.x issue first seen in 0.21.x feature/rewards product/user-happiness QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include suggestion
Projects
None yet
Milestone
0.21.x (Release Channel)
Development

No branches or pull requests
9 participants
@alexwykoff @kjozwiak @luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv @LaurenWags @btlechowski