Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

tab page (full of tabs) cannot be previewed #11269

Closed
luixxiul opened this issue Oct 4, 2017 · 0 comments · Fixed by #11407
Closed

tab page (full of tabs) cannot be previewed #11269

luixxiul opened this issue Oct 4, 2017 · 0 comments · Fixed by #11407
Assignees
@cezaraugusto
Labels
bug feature/tab-page feature/tab-preview QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 4, 2017 •
edited
Loading

Test plan

  1. Open enough tabs to create a second tab page
  2. Change the tab page
  3. Hover on the indicator of the other tab page
  4. Make sure the tab page is previewed

Description

tab page (full of tabs) cannot be previewed.

tab

automated test tab pages tab page previews hovering over a tab page changes it failing on master.

brave-mbp:browser-laptop Suguru$ BRAVE_TEST_COMMAND_LOGS=1 npm run test -- --grep='over a tab page changes it'

> brave@0.21.0 test /Users/Suguru/browser-laptop
> cross-env NODE_ENV=test mocha "test/**/*Test.js" "--grep=over a tab page changes it"



  tab pages
    tab page previews
waitForUrl("chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/about-newtab.html")
tabByUrl("chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/about-newtab.html")
tabHandles()
tabByUrl("chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/about-newtab.html") => {"sessionId":"9618f3c9abe92ce4f4ca94c722c3af7a","status":0,"value":null}
waitForBrowserWindow()
windowByUrl("chrome://brave/Users/Suguru/browser-laptop/app/extensions/brave/index.html")
windowByUrl("chrome://brave/Users/Suguru/browser-laptop/app/extensions/brave/index.html") => ["chrome://brave/Users/Suguru/browser-laptop/app/extensions/brave/index.html"]
waitForBrowserWindow() => {"sessionId":"9618f3c9abe92ce4f4ca94c722c3af7a","status":0,"value":null}
changeSetting("tabs.tabs-per-page", "20")
waitForSettingValue(tabs.tabs-per-page, 20)
getAppState()
20
windowByUrl("chrome://brave/Users/Suguru/browser-laptop/app/extensions/brave/index.html")
windowByUrl("chrome://brave/Users/Suguru/browser-laptop/app/extensions/brave/index.html") => ["chrome://brave/Users/Suguru/browser-laptop/app/extensions/brave/index.html"]
waitForElementCount(".tabs [data-test-id="tab"]", 2)
waitForElementCount(".tabs [data-test-id="tab"]", 2) => 2
waitForElementCount(".tabs [data-test-id="tab"]", 3)
waitForElementCount(".tabs [data-test-id="tab"]", 3) => 2
waitForElementCount(".tabs [data-test-id="tab"]", 3) => 3
waitForElementCount(".tabs [data-test-id="tab"]", 4)
waitForElementCount(".tabs [data-test-id="tab"]", 4) => 4
waitForElementCount(".tabs [data-test-id="tab"]", 5)
waitForElementCount(".tabs [data-test-id="tab"]", 5) => 4
waitForElementCount(".tabs [data-test-id="tab"]", 5) => 5
waitForElementCount(".tabs [data-test-id="tab"]", 6)
waitForElementCount(".tabs [data-test-id="tab"]", 6) => 6
waitForElementCount(".tabs [data-test-id="tab"]", 7)
waitForElementCount(".tabs [data-test-id="tab"]", 7) => 6
waitForElementCount(".tabs [data-test-id="tab"]", 7) => 7
waitForElementCount(".tabs [data-test-id="tab"]", 8)
waitForElementCount(".tabs [data-test-id="tab"]", 8) => 7
waitForElementCount(".tabs [data-test-id="tab"]", 8) => 8
waitForElementCount(".tabs [data-test-id="tab"]", 9)
waitForElementCount(".tabs [data-test-id="tab"]", 9) => 8
waitForElementCount(".tabs [data-test-id="tab"]", 9) => 9
waitForElementCount(".tabs [data-test-id="tab"]", 10)
waitForElementCount(".tabs [data-test-id="tab"]", 10) => 9
waitForElementCount(".tabs [data-test-id="tab"]", 10) => 10
waitForElementCount(".tabs [data-test-id="tab"]", 11)
waitForElementCount(".tabs [data-test-id="tab"]", 11) => 10
waitForElementCount(".tabs [data-test-id="tab"]", 11) => 11
waitForElementCount(".tabs [data-test-id="tab"]", 12)
waitForElementCount(".tabs [data-test-id="tab"]", 12) => 11
waitForElementCount(".tabs [data-test-id="tab"]", 12) => 12
waitForElementCount(".tabs [data-test-id="tab"]", 13)
waitForElementCount(".tabs [data-test-id="tab"]", 13) => 12
waitForElementCount(".tabs [data-test-id="tab"]", 13) => 13
waitForElementCount(".tabs [data-test-id="tab"]", 14)
waitForElementCount(".tabs [data-test-id="tab"]", 14) => 13
waitForElementCount(".tabs [data-test-id="tab"]", 14) => 14
waitForElementCount(".tabs [data-test-id="tab"]", 15)
waitForElementCount(".tabs [data-test-id="tab"]", 15) => 14
waitForElementCount(".tabs [data-test-id="tab"]", 15) => 15
waitForElementCount(".tabs [data-test-id="tab"]", 16)
waitForElementCount(".tabs [data-test-id="tab"]", 16) => 15
waitForElementCount(".tabs [data-test-id="tab"]", 16) => 16
waitForElementCount(".tabs [data-test-id="tab"]", 17)
waitForElementCount(".tabs [data-test-id="tab"]", 17) => 16
waitForElementCount(".tabs [data-test-id="tab"]", 17) => 17
waitForElementCount(".tabs [data-test-id="tab"]", 18)
waitForElementCount(".tabs [data-test-id="tab"]", 18) => 17
waitForElementCount(".tabs [data-test-id="tab"]", 18) => 18
waitForElementCount(".tabs [data-test-id="tab"]", 19)
waitForElementCount(".tabs [data-test-id="tab"]", 19) => 18
waitForElementCount(".tabs [data-test-id="tab"]", 19) => 19
waitForElementCount(".tabs [data-test-id="tab"]", 20)
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 19
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 20
waitForElementCount(".tabs [data-test-id="tab"]", 1)
waitForElementCount(".tabs [data-test-id="tab"]", 1) => 20
waitForElementCount(".tabs [data-test-id="tab"]", 1) => 1
waitForElementCount(".tabPage", 2)
waitForElementCount(".tabPage", 2) => 2
waitForElementCount(".tabs [data-test-id="tab"]", 20)
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1
      1) hovering over a tab page changes it
waitForBrowserWindow()
windowByUrl("chrome://brave/Users/Suguru/browser-laptop/app/extensions/brave/index.html")
waitForElementCount(".tabs [data-test-id="tab"]", 20) => 1


  0 passing (25s)
  1 failing

  1) tab pages tab page previews hovering over a tab page changes it:
     Promise was rejected with the following reason: timeout
  Error

Steps to Reproduce

  1. BRAVE_TEST_COMMAND_LOGS=1 npm run test -- --grep='over a tab page changes it'

Actual result:

See above

Expected result:

The tab page should be previewed

Reproduces how often: [What percentage of the time does it reproduce?]

Brave Version

about:brave info:

de5f381

Reproducible on current live release:

Additional Information
@cezaraugusto cezaraugusto added this to the 0.20.x (Developer Channel) milestone Oct 9, 2017
cezaraugusto added a commit that referenced this issue Oct 10, 2017
@cezaraugusto
fix bad tab page preview for the first tab set
fe38a57 
fix #11269
Auditors: @luixxiul
Test Plan:
npm run test -- --grep="tab pages tab page previews hovering over a tab page changes it"
@cezaraugusto cezaraugusto mentioned this issue Oct 10, 2017
Merged
@luixxiul luixxiul mentioned this issue Oct 10, 2017
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
fix bad tab page preview for the first tab set
539389b 
fix brave#11269
Auditors: @luixxiul
Test Plan:
npm run test -- --grep="tab pages tab page previews hovering over a tab page changes it"
This was referenced Dec 20, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/tab-page feature/tab-preview QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix bad tab page preview for the first tab set brave/browser-laptop
4 participants
@luixxiul @cezaraugusto @srirambv @LaurenWags