bookmark "star" icon under URL not being updated right way when dragging and dropping

[kjozwiak]

Description

When dragging and dropping a website into the "Bookmarks Toolbar" via the URL bar, the "star" bookmark icon under the URL bar won't be updated until either:

• refresh the tab
• switch to a different tab, return to the tab that was just bookmarked

Steps to Reproduce

1. launch 0.19.28 and enable the "Bookmarks Toolbar"
2. visit any website, drag and drop it into the "Bookmarks Toolbar" via the "lock" icon
3. the star should appear once the website has been added into the "Bookmarks Toolbar"
4. remove the newly created bookmark from the "Bookmarks Toolbar"
5. repeat 2 and drop the same website into the "Bookmarks Toolbar" once again

Actual result:

You'll notice that the "star" icon under the URL isn't being updated when the website is bookmarked via drag and drop.

Expected result:

The "star" icon under the URL should be updated as soon as the website has been dropped into the "Bookmarks Toolbar"

Reproduces how often: [What percentage of the time does it reproduce?]

Reproducible 100% of the time using the above STR.

Brave Version

about:brave info:

Brave: 0.19.28
rev: 08781a5
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 16.7.0
OS Architecture: x64

Reproducible on current live release:

This is working correctly under 0.18.36 and appears to be a recent regression in 0.19.x.

[bbondy]

0.19.x: de2caca
0.20.x: 8e97420
This is not landing on master because there's a big refactor going on there.

[kjozwiak]

This didn't land into 0.19.33. However, I had the incorrect STR which made it seemed like it was fixed. Edited the original comment to include the correct STR.