Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Autocomplete search results show gibberish when typing non-ASCII characters #11297

Closed
Jacalz opened this issue Oct 5, 2017 · 3 comments · Fixed by #12173
Closed

Autocomplete search results show gibberish when typing non-ASCII characters #11297

Jacalz opened this issue Oct 5, 2017 · 3 comments · Fixed by #12173

Comments

@Jacalz
Copy link
Contributor

Jacalz commented Oct 5, 2017

Test plan

See #12173

Description

Typing Å or Ä or Ö in the address bar just gets you jibberish text that is totally unreadable

Steps to Reproduce

  1. Write in the address bar with these symbols
  2. See how it returns the symbols as jibberish

Actual result:

Text is jibberish, can see any of those letters in the suggestions
image

Expected result:
SHould see ÅÄÖ in the suggestions
Reproduces how often: [What percentage of the time does it reproduce?]
Every time

Brave Version

0.19.29 and beyond
about:brave info:

Name Version
Brave 0.19.29
rev c10b3ea
Muon 4.4.25
libchromiumcontent 61.0.3163.100
V8 6.1.534.41
Node.js 7.9.0
Update Channel Beta
OS Platform Microsoft Windows
OS Release 10.0.15063
OS Architecture x64

Reproducible on current live release:

Yes

Additional Information

You might need a Swedish keyboard to replicate

@luixxiul
Copy link
Contributor

luixxiul commented Oct 5, 2017

Could we close this in favor of #9139 ?

@Jacalz
Copy link
Contributor Author

Jacalz commented Oct 5, 2017

Is it really the same as that one? I can´t tell really, seem a bit different

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@darkdh darkdh self-assigned this Dec 4, 2017
darkdh added a commit that referenced this issue Dec 5, 2017
fix #11297

Auditors: @bsclifton, @bbondy

Test Plan:
1. Go to about:preferences#search and turn on
  `Autocomplete search term as you type`
2. Set search engine to Google (ISO-8859-1)
3. Type "功德" on URL input
4. There shouldn't be any jibberish results
5. Set search engine to Bing/DDG (UTF-8)
6. Type "功德" on URL input
7. There shouldn't be any jibberish results
@bsclifton bsclifton modified the milestones: Triage Backlog, 0.21.x (Developer Channel) Dec 23, 2017
@bsclifton bsclifton changed the title ÅÄÖ in address bar is viewed as jibberish Autocomplete search results show gibberish when typing non-ASCII characters Feb 9, 2018
bsclifton pushed a commit that referenced this issue Feb 9, 2018
fix #11297

Auditors: @bsclifton, @bbondy

Test Plan:
1. Go to about:preferences#search and turn on
  `Autocomplete search term as you type`
2. Set search engine to Google (ISO-8859-1)
3. Type "功德" on URL input
4. There shouldn't be any jibberish results
5. Set search engine to Bing/DDG (UTF-8)
6. Type "功德" on URL input
7. There shouldn't be any jibberish results
@srirambv
Copy link
Collaborator

srirambv commented Mar 22, 2018

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on Ubuntu 10.10 x64

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.