QR codes not being displayed when creating a new wallet

[kjozwiak]

Description

When creating a new wallet, you'll notice that the QR codes are not being displayed under the "Add Fund" manager.

Steps to Reproduce

1. launch the latest brave (0.19.48 was being used in this instance)
2. create a new wallet under about:preferences#payments
3. select "Add Funds" and click on any cryptocurrency that's listed in the manager

Actual result:

QR code isn't being displayed.

Expected result:

QR code should be visible as another way of adding funds into the wallet.

Reproduces how often: [What percentage of the time does it reproduce?]

100% reproducible using the above STR.

Brave Version

about:brave info:

Brave: 0.19.48
rev: de939f6
Muon: 4.4.28
libchromiumcontent: 61.0.3163.100

Reproducible on current live release:

No, part of BAT which is being introduced in 0.19.x

[bsclifton]

I believe I found the issue

This call should be generating the code- it's never getting called:

browser-laptop/app/browser/api/ledger.js

Line 1735 in a314b4e

state = generatePaymentData(state)

I believe this was broken here:
c965002#diff-3cdfdb124f718787d584e9e2b82fcedcR1720

Because the unconfirmed amount is 0 (which matches the state), it returns without making the call. Looking into a fix...

[kjozwiak]

Also checked the following under Ubuntu 17.04 x64:

• ensure that the QR codes are appearing when creating a new wallet with a clean profile under 0.19.52
• ensure that the QR codes are appearing when upgrading from 0.19.36 -> '0.19.52'
• esnure that the QR codes are appearing once a wallet as been recovered under '0.19.52'