metamask notification should be tab-specific #11535

diracdeltas · 2017-10-15T02:21:08Z

the metamask notification refers to the page below it, but it's still there when you switch tabs. ex:

correct tab -

incorrect tab -

@bbondy

fix #11535 fix #11536 Auditors: @bbondy, @diracdeltas Test Plan:

@bbondy

fix #11535 fix #11536 Auditors: @bbondy, @diracdeltas Test Plan:

@bbondy

fix #11535 fix #11536 Auditors: @bbondy, @diracdeltas Test Plan:

kjozwiak · 2017-10-16T19:44:27Z

STR/Test Case:

create a new tab and visit https://ethwaterloo.herokuapp.com/, ensure that you receive a "Dapp" notification
create a new tab and ensure that you're not seeing the "Dapp" notification that was spawned from https://ethwaterloo.herokuapp.com/
create a new tab and visit https://brianbondy.com/, ensure you're not seeing any "Dapp" notifications
create a new tab and visit https://www.stateofthedapps.com/dapps/adchainregistry, ensure that you receive a "Dapp" notification
create a new tab and ensure that you're not seeing the "Dapp" notification that was spawned from https://www.stateofthedapps.com/dapps/adchainregistry
create a new tab and visit https://clifton.io/, ensure you're not seeing any "Dapp" notifications
switch to the https://ethwaterloo.herokuapp.com/ tab, ensure that the "Dapp" notification is still being displayed
switch to the https://brianbondy.com/ tab, ensure that you're NOT seeing any "Dapp" notifications
switch to the https://www.stateofthedapps.com/dapps/adchainregistry tab, ensure that the "Dapp" notification is still being displayed
switch to the https://clifton.io/ tab, ensure that you're NOT seeing any "Dapp" notifications

@bbondy

fix brave#11535 fix brave#11536 Auditors: @bbondy, @diracdeltas Test Plan:

bbondy added this to the 0.19.x Hotfix 1 (Release channel) milestone Oct 15, 2017

darkdh self-assigned this Oct 15, 2017

darkdh added a commit that referenced this issue Oct 15, 2017

Fix metamask notification

5b9b313

fix #11535 fix #11536 Auditors: @bbondy, @diracdeltas Test Plan:

darkdh mentioned this issue Oct 15, 2017

Fix metamask notification #11539

Closed

8 tasks

kjozwiak pushed a commit that referenced this issue Oct 15, 2017

Fix metamask notification

f2b101a

fix #11535 fix #11536 Auditors: @bbondy, @diracdeltas Test Plan:

bbondy pushed a commit that referenced this issue Oct 15, 2017

Fix metamask notification

f0ba80b

fix #11535 fix #11536 Auditors: @bbondy, @diracdeltas Test Plan:

bbondy closed this as completed in 24b6cb9 Oct 15, 2017

luixxiul added release-notes/exclude QA/test-plan-required labels Oct 15, 2017

kjozwiak added QA/test-plan-specified and removed QA/test-plan-required labels Oct 16, 2017

srirambv added the QA/checked-Win64 label Oct 16, 2017

LaurenWags added the QA/checked-macOS label Oct 16, 2017

kjozwiak added QA/checked-Linux QA/checked-Win32 labels Oct 16, 2017

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017

Fix metamask notification

e9be288

fix brave#11535 fix brave#11536 Auditors: @bbondy, @diracdeltas Test Plan:

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

metamask notification should be tab-specific #11535

metamask notification should be tab-specific #11535

diracdeltas commented Oct 15, 2017

kjozwiak commented Oct 16, 2017

metamask notification should be tab-specific #11535

metamask notification should be tab-specific #11535

Comments

diracdeltas commented Oct 15, 2017

kjozwiak commented Oct 16, 2017