Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Don't execute script for Dapp detection after being dismissed #11537

Closed
bbondy opened this issue Oct 15, 2017 · 1 comment
Closed

Don't execute script for Dapp detection after being dismissed #11537

bbondy opened this issue Oct 15, 2017 · 1 comment
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x Hotfix 1 (...

Comments

@bbondy
Copy link
Member

bbondy commented Oct 15, 2017

No description provided.

@kjozwiak kjozwiak changed the title Use a content setting to not execute script from content scripts at all if Dapps prompt is already dismissed Don't execute script for Dapp detection after being dismissed Oct 15, 2017
kjozwiak added a commit that referenced this issue Oct 15, 2017
@kjozwiak
Don't execute script for Dapp detection after being dismissed
37838ae 
Fix #11537
bbondy pushed a commit that referenced this issue Oct 15, 2017
@kjozwiak @bbondy
Don't execute script for Dapp detection after being dismissed
6bebecf 
Fix #11537
@bbondy bbondy closed this as completed in b3f61ee Oct 15, 2017
This was referenced Oct 16, 2017
Closed
Closed
Closed
Closed
@kjozwiak
Copy link
Member

STR/Test Plan:

  • visit https://tokenfactory.surge.sh and ensure that you receive the "Dapp" notification
  • open the developer tools for https://tokenfactory.surge.sh via "option + cmd + i"
  • expand <head></head> under "Elements" and ensure that <meta name="web3-installed"> is present
  • ensure "Remember this decision" is selected and click on "No Thanks"
  • refresh the page and ensure that you're not getting the "DApp" notification
  • open the developer tools for https://tokenfactory.surge.sh via "option + cmd + i"
  • expand <head></head> under "Elements" and ensure that <meta name="web3-installed"> is NOT BEING injected into the header

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@kjozwiak @syuan100
Don't execute script for Dapp detection after being dismissed
3d20846 
Fix brave#11537
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 1 (Release channel)
Development

No branches or pull requests
5 participants
@bbondy @kjozwiak @luixxiul @srirambv @LaurenWags