Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reports of tabs session lost on upgrade #11576

Closed
bbondy opened this issue Oct 17, 2017 · 16 comments
Closed

Reports of tabs session lost on upgrade #11576

bbondy opened this issue Oct 17, 2017 · 16 comments
Assignees
@bsclifton @darkdh
Labels
0.19.x issue first seen in 0.19.x addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. bug priority/P2 Crashes. Loss of data. Severe memory leak. wontfix

Comments

@bbondy
Copy link
Member

bbondy commented Oct 17, 2017 •
edited by bsclifton
Loading

Original issue description

I saw one report on twitter that lost current tabs / windows. Also Brendan lost partial Windows after the last upgrade. For Brendan he mentions that the browser didn't restart after update as a clue for where to look.
@ghost ghost added the release/blocking label Oct 17, 2017
@bsclifton bsclifton added the needs-info Another team member needs information from the PR/issue opener. label Oct 17, 2017
@bsclifton
Copy link
Member

We're going to need more info on this one

I do remember an issue previously about window state loss after upgrade, which I believe you had fixed @bbondy. I'm going to see if I can find more data so that we can properly investigate this

@bsclifton
Copy link
Member

Important details

  • browser didn't restart after update
  • only some windows were lost (from the window state), not all of them

@bsclifton
Copy link
Member

@darkdh tried multiple upgrade scenarios using 6 windows and was unable to repro. @kjozwiak will be trying to help repro and I'll be looking at the session code (I have an idea of where the problem may be)

@LaurenWags
Copy link
Member

Haven't been able to repro 100%, however 3 times this caused partial loss:
Have profile with several windows/tabs on 0.18.36.
Get notification to update. Select 'Details' button. Click 'Later' button.
Go about your business (detach a tab which starts a new window, in this new window open new tabs, detach a tab from this new window).
Close Brave. (at this point, in all my tests Brave reopened)
However, a few times (3) the tabs/windows modified after selecting 'Later' were not present on restart.

@bsclifton bsclifton mentioned this issue Oct 19, 2017
Merged
8 tasks
@luixxiul luixxiul added the 0.19.x issue first seen in 0.19.x label Nov 2, 2017
@bbondy bbondy added the priority/P2 Crashes. Loss of data. Severe memory leak. label Nov 7, 2017
@bbondy bbondy modified the milestones: 0.19.x Hotfix 4 (Release channel), Prioritized Backlog Nov 7, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bsclifton @syuan100
Hardening the session store saving code
eb312f8 
Should help with brave#11576

Auditors: @darkdh
@bsclifton
Copy link
Member

bsclifton commented Nov 10, 2017 •
edited
Loading

related #9390, #7565

@bsclifton
Copy link
Member

Working on repro... @BrendanEich shared the following (related to losing window state):

I've been losing windows on update to new stable version, and figured out something: Windows menu won't list a window with focused tab loading https://rendertoken.com/ -- that tab shows as black background with spinner spinning. If I focus the URL bar and type that URL in, still won't load but does retain the URL. If I cmd-W to close and cmd-shift-tab to reopen, then it loads -- and I see the window listed and counted in Windows menu.

@bsclifton bsclifton mentioned this issue Mar 2, 2018
Closed
@bsclifton bsclifton added the bug label Mar 2, 2018
darkdh added a commit that referenced this issue Mar 13, 2018
@darkdh
Avoid serializing Function in array template
1fb6101 
fix #13421
fix #11576

Auditors: @bridiver

Test Plan:
1. Set `sessionSaveInterval` to `1` in js/constants/appConfig.js
2. Playing around with bookmark toolbar folder
3. Playing around with auotfill menu(fill with entry and clear)
4. Playing around with hamburger menu
5. Playing around with back/forward long pressed menu
6. There shouldn't be any exceptions about "function can be cloned"
@darkdh darkdh mentioned this issue Mar 13, 2018
Merged
10 tasks
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.21.x w/ Chromium 65 (Beta Channel) Mar 13, 2018
@bsclifton bsclifton removed the needs-info Another team member needs information from the PR/issue opener. label Mar 16, 2018
bsclifton pushed a commit that referenced this issue Mar 16, 2018
@darkdh @bsclifton
Avoid serializing Function in array template
77e3671 
fix #13421
fix #11576

Auditors: @bridiver

Test Plan:
1. Set `sessionSaveInterval` to `1` in js/constants/appConfig.js
2. Playing around with bookmark toolbar folder
3. Playing around with auotfill menu(fill with entry and clear)
4. Playing around with hamburger menu
5. Playing around with back/forward long pressed menu
6. There shouldn't be any exceptions about "function can be cloned"
@kjozwiak kjozwiak mentioned this issue Mar 16, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Mar 16, 2018
Closed
@esmail
Copy link

esmail commented Mar 17, 2018

Wish I could appreciate the humorous irony in first experiencing this upgrade-triggered issue after upgrading to the release that was supposed to fix it, but losing all of my (many) tabs again has been a major drag.

When I opened up Brave after upgrading to 0.21.19, my windows were "restored" with what appears to be their previous sizes and positions, but all tabs were gone, replaced with one single blank tab per window. These tabs were literally blank in that they aren't even showing the about-newtab.html. When I "Reopen Last Closed Tab" it only restores the tabs that I previously closed manually.

I've tried restoring a previous session-store-1 as recommended in #5512, but no luck. Any alternatives?

@LaurenWags
Copy link
Member

@esmail I believe you encountered the issue I opened and linked (#13483). Unfortunately I don't have any suggestions for you, I lost my tabs too 😞

@bsclifton bsclifton reopened this Mar 19, 2018
@bsclifton bsclifton modified the milestones: 0.21.x w/ Chromium 65 (Release Channel), Backlog (Prioritized) Mar 19, 2018
@bsclifton
Copy link
Member

Definitely looks like this is not fixed ☹️

Please note that if you choose Home page or New tab (instead of the default)
screen shot 2018-03-19 at 10 20 42 am

You will unfortunately lose your window / tab state on application launch. We do have an issue captured to keep window / tab state on upgrade only (please see #8625)

We'll need to investigate this more to find the root cause. Often times, it can be an exception when trying to write the session to disk (one of which @darkdh fixed). Seems that we have some other use-cases to fix too. Stay tuned

@bsclifton bsclifton reopened this Mar 20, 2018
@bsclifton
Copy link
Member

bsclifton commented Mar 20, 2018 •
edited
Loading

NOTE: Close above happened automatically when Chromium 65 branch was merged to master. I manually re-opened (thanks @darkdh)

@kjozwiak kjozwiak mentioned this issue Mar 20, 2018
Closed
@esmail
Copy link

esmail commented Mar 22, 2018

@LaurenWags and @bsclifton, clearly the window/tab states must exist somewhere in my backup (I'm assuming you haven't forced the settings into NVRAM or made history and somehow found a way to keep them resident in volatile RAM while my computer's shut down).

So my question for now is has the file format irretrievably changed, in which case I could temporarily roll back to an older version of Brave and get my precious tabs, or was session-store-1 the wrong file to restore?

@bsclifton
Copy link
Member

Hi @esmail

Unfortunately no- the window and tab state is only stored in session-store-1. If restoring this did not restore your windows or tabs, you have lost them. There are some edge-cases where this can happen (which it sounds like you ran into). We're still working to fix as many of those as possible ☹️

@bsclifton bsclifton added wontfix addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. labels Sep 1, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 1, 2018
@bsclifton
Copy link
Member

Unfortunately, I don't think we'll have a short-term fix for this. However, this problem should not occur once we move over to brave-core

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

@darkdh darkdh

Labels
0.19.x issue first seen in 0.19.x addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. bug priority/P2 Crashes. Loss of data. Severe memory leak. wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@bbondy @esmail @kjozwiak @luixxiul @bsclifton @NejcZdovc @darkdh @LaurenWags @btlechowski