This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
LastPass Vault Issue #11624
Assignees
Labels
Milestone
Comments
|
Another use reported the same feedback on Twitter (but on Linux), with largely the same console output.
|
|
I wonder if this is fixed in our latest version - can anyone verify? (0.23.73) If it's complaining about the locale, it may still be an issue (ex: calling an API we don't support yet). In that case, it would likely be fixed with Brave Core |
|
@bsclifton Still broken for me in 0.23.73. The problem is with the format of our response to Brave:
|
|
Assigning @darkdh, as he's taken a look at the underlying logic and may have a solution. |
darkdh
added a commit
to brave/muon
that referenced
this issue
Aug 2, 2018
`BraveContentBrowserClient::GetApplicationLocale` because the result of `extension_l10n_util::CurrentLocaleOrDefault` will be normalized by `l10n_util::NormalizeLocale` which means turning en-US to en_US `chrome.i18n.getUILanguage` uses `RenderThread::GetLocale()` which reads from switch `--lang` appended when renderer process created and the value is reading from `ContentBrowserClient::GetApplicationLocale` fix brave/browser-laptop#11624 Auditors: @bridiver, @bbondy
|
@jonathansampson @darkdh do you have test steps you can add for this? 😄 |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
per @darkdh:
Original issue description
Description
LastPass Vault does not display any saved passwords.
Steps to Reproduce
Actual result:
Expected result:
I am unable to generate the expected result.
Reproduces how often: [What percentage of the time does it reproduce?]
Everytime.
Brave Version
about:brave info:
Reproducible on current live release:
Yes. This issue has presented itself on 2 separate PCs (Windows 8.1 and Windows 10) since the upgrading to the latest release version.
Additional Information
The text was updated successfully, but these errors were encountered: