Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

import : selector dropdown can be exceedingly wide if the user has a Chrome profile with a long name #11646

Closed
alexwykoff opened this issue Oct 24, 2017 · 2 comments
Closed

import : selector dropdown can be exceedingly wide if the user has a Chrome profile with a long name #11646

alexwykoff opened this issue Oct 24, 2017 · 2 comments
Labels
bug priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/test-plan-specified release-notes/include stale

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Oct 24, 2017 •
edited by luixxiul
Loading

Test plan

#11648 (comment)

Description

If the user has a Chrome profile with a long name, and they attempt to import the information into Brave, the selector can display well beyond the bounds of the import modal.

Steps to Reproduce

  1. Create a Chrome profile with a ridiculously long name
  2. Attempt to import into Brave, check dropdown width

Actual result:
Reeeeallly wide dropdown menu.

screen shot 2017-10-23 at 5 24 55 pm

Expected result:
Normalish wide dropdown menu, probably truncating the profile name and using ellipsis.

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

about:brave info:
0.19.62 (fe3f350)

Reproducible on current live release:
Haven't tried yet.

Additional Information
@alexwykoff alexwykoff added bug needs-triage priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). labels Oct 24, 2017
@luixxiul luixxiul self-assigned this Oct 24, 2017
@luixxiul luixxiul mentioned this issue Oct 24, 2017
Merged
8 tasks
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Oct 28, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@syuan100
Set max-width to dropdown
9ab63e7 
Fixes brave#11646

Note that you cannot truncate the profile name with CSS because option element simply cannot be styled using CSS. See: https://developer.mozilla.org/en-US/docs/Learn/HTML/Forms/Styling_HTML_forms

Auditors: @cezaraugusto

Test Plan:
1. Create a Chrome profile with a long name
2. Open Import browser data dialog
3. Make sure that the dropdown wrapper does not overflow the dialog
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
This was referenced Jun 19, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

Still happens on the latest build
image

@srirambv srirambv reopened this Jun 19, 2018
@bsclifton
Copy link
Member

Removing from milestone

@bsclifton bsclifton removed this from the Triage Backlog milestone Jun 21, 2018
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Jun 21, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 3, 2018
@bsclifton bsclifton added the stale label Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/test-plan-specified release-notes/include stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bbondy @alexwykoff @luixxiul @bsclifton @NejcZdovc @srirambv