Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Default download path is not working #11649

Closed
NejcZdovc opened this issue Oct 24, 2017 · 1 comment · Fixed by #11654
Closed

Default download path is not working #11649

NejcZdovc opened this issue Oct 24, 2017 · 1 comment · Fixed by #11654

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 24, 2017

Description

Default downland path is not working. This is working on

Steps to Reproduce

  1. Set default download path in about:preferences
  2. Disable Always ask me where to save files
  3. Go to https://brave.com/about/Brave_proudly-partner_badges.zip

Actual result:

In my case (macOS) file is saved in Download folder

Expected result:
File is saved in folder defined with default download path

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

WORKING

Brave: 0.19.54
rev: 7ce342d
Muon: 4.4.29
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Beta
OS Platform: macOS
OS Release: 17.0.0
OS Architecture: x64

NOT WORKING

Name Version
Brave 0.19.62
rev 9c33f43
Muon 4.5.7
libchromiumcontent 62.0.3202.62
V8 6.2.414.32
Node.js 7.9.0
Update Channel Release
OS Platform macOS
OS Release 17.0.0
OS Architecture x64

Reproducible on current live release:

no

Additional Information

@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Oct 24, 2017

we have tests for this use case in 0.21.x and up. They are failing https://travis-ci.org/brave/browser-laptop/jobs/291943515#L4047

captured here #11516

@kjozwiak kjozwiak changed the title Default downland path is not working Default download path is not working Oct 24, 2017
bridiver added a commit that referenced this issue Oct 24, 2017
update user pref on setting change
fix #11649
bridiver added a commit that referenced this issue Oct 24, 2017
update user pref on setting change
fix #11649
NejcZdovc pushed a commit that referenced this issue Oct 25, 2017
update user pref on setting change
fix #11649
cezaraugusto pushed a commit that referenced this issue Oct 27, 2017
update user pref on setting change
fix #11649
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
update user pref on setting change
fix brave#11649
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.