Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Moving bookmark into folder removes title and address and cannot delete it #11672

Closed
srirambv opened this issue Oct 25, 2017 · 9 comments
Closed

Comments

@srirambv
Copy link
Collaborator

Description

Moving bookmark into folder removes title and address and cannot delete it

Steps to Reproduce

  1. Clean install 0.19.66
  2. Add a bookmark, click on edit bookmark,click on remove, should remove the bookmark
  3. Create a bookmark folder, add a bookmark, move it into folder
  4. Click on bookmark icon again, address and title is missing, clicking on remove doesn't delete the bookmark

Actual result:
bookmark

Expected result:
Should be deleted even if its under folder

Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

about:brave info:

Brave 0.19.66
rev 148f5b0
Muon 4.5.9

Reproducible on current live release:
Yes, broken in all 0.19.x release, works fine on 0.18.36

Additional Information

@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Oct 25, 2017
@NejcZdovc
Copy link
Contributor

@srirambv can you please check if this is reproducible on 0.21.x?

@srirambv
Copy link
Collaborator Author

@NejcZdovc it works fine on 0.21.x (729c840)

@cezaraugusto
Copy link
Contributor

I'm on 0.20.x sha b86fafe and couldn't reproduce. @srirambv mind checking again if works there?

@cezaraugusto
Copy link
Contributor

also confirmed the above in 0.21.x unable to reproduce sha 27f560b

@cezaraugusto cezaraugusto added the needs-info Another team member needs information from the PR/issue opener. label Oct 26, 2017
@bbondy
Copy link
Member

bbondy commented Oct 27, 2017

re-open if not fixed, thanks.

@bbondy bbondy closed this as completed Oct 27, 2017
@srirambv
Copy link
Collaborator Author

@cezaraugusto @bbondy Able to repro this on 0.20.x sha 087853d.
11672

@srirambv srirambv reopened this Oct 27, 2017
@cezaraugusto
Copy link
Contributor

still can't repro. sha ea8929b which is one before latest in 0.20.x

screen shot 2017-10-27 at 2 41 35 pm

1 oct-27-2017 14-47-49

@bsclifton
Copy link
Member

bsclifton commented Oct 29, 2017

@srirambv 0.20.0 was recently overwritten with 0.21.x... looking at your commit hash, that is the old one (not the new one which Cezar mentions above, which is fixed).

You'll need to do a git fetch origin and pull in latest. You'll likely get a conflict, so you can run:

git checkout 0.20.x
git fetch origin
git reset --hard origin/0.20.x

@srirambv
Copy link
Collaborator Author

Verified can't repro this on a42cac1 which is latest on 0.20.x. Did find another issue with bookmark toolbar right click context menu on 0.20.x will log a separate issue for it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.