Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bookmarked icon keeps displayed after the bookmark is deleted #10348

Closed
luixxiul opened this issue Aug 9, 2017 · 6 comments
Closed

Bookmarked icon keeps displayed after the bookmark is deleted #10348

luixxiul opened this issue Aug 9, 2017 · 6 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Aug 9, 2017

Describe the issue you encountered: Bookmarked icon keeps displayed after the bookmark is moved to a bookmark folder and deleted.

screenshot 2017-08-09 10 49 11

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): master branch

  • Steps to reproduce:

    1. Bookmark twitter.com
    2. Create a bookmark folder
    3. Move the bookmark into the folder
    4. Delete the bookmark
  • Actual result: the bookmarked icon is still displayed

  • Expected result: it should not

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues:

@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 9, 2017
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 9, 2017

This is the log on the devtool console

http://localhost:8080/gen/app.entry.js:60926: Uncaught TypeError: Cannot read property 'create' of undefined{TypeError: Cannot read property 'create' of undefined
    at EventEmitter.ipc.on (http://localhost:8080/gen/app.entry.js:60926:34)
    at emitTwo (extensions::event_emitter:105:13)
    at EventEmitter.emit (extensions::event_emitter:193:7)
    at EventEmitter.ipcRenderer.emit (extensions::ipc_utils:31:22)}

@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 9, 2017

related: #10353 (comment)

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 9, 2017
Resolves brave#10296
Resolves brave#10348

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 9, 2017
Resolves brave#10296
Resolves brave#10348

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 20, 2017
Resolves brave#10296
Resolves brave#10348
Resolves brave#10310

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 20, 2017
Resolves brave#10296
Resolves brave#10348
Resolves brave#10503

Auditors:

Test Plan:
@ghost ghost added the sprint/1 label Sep 13, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@cezaraugusto
Copy link
Contributor

@luixxiul could you confirm this is still a thing? this is very similar to #11672.

I'm on 0.20.x and couldn't reproduce both. Also tried on 0.21.x and master, works normally.

@cezaraugusto cezaraugusto added the needs-info Another team member needs information from the PR/issue opener. label Oct 26, 2017
@bbondy bbondy removed the sprint/1 label Oct 27, 2017
@NejcZdovc
Copy link
Contributor

this is fixed in #10310

@NejcZdovc
Copy link
Contributor

but I already fixed it in dc49efa which is already merged

@luixxiul
Copy link
Contributor Author

luixxiul commented Nov 7, 2017

confirmed it's been fixed 👍

@luixxiul luixxiul added QA/checked-Linux and removed needs-info Another team member needs information from the PR/issue opener. labels Nov 7, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Nov 7, 2017
Resolves brave#10296
Resolves brave#10348
Resolves brave#10503

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Nov 24, 2017
Resolves brave#10296
Resolves brave#10348
Resolves brave#10503

Auditors:

Test Plan:
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.