Follow up for sites splits PR #10296 #10310

NejcZdovc · 2017-08-06T19:26:06Z

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.

Resolves #10296

Auditors:

Test Plan: covered with automated tests

Reviewer Checklist:

Tests

Adequate test coverage exists to prevent regressions
Tests should be independent and work correctly when run individually or as a suite ref
New files have MPL2 license header

NejcZdovc · 2017-08-20T15:04:57Z

blocked by

~~Moves bookmark text calculation into the state #10325~~ merged
~~Fixes Other bookmarks not being usable #10610~~ merged
~~Fixes bookmark move location cache #10819~~ merged
~~Fixes removal of bookmarkLocation cache when removing bookmark folder #10909~~ merged

Resolves brave#10296 Resolves brave#10348 Resolves brave#10310 Auditors: Test Plan:

cezaraugusto · 2017-10-28T03:34:21Z

@NejcZdovc I'm going to close as stale for now please re-open when you have a window. Thanks!

bsclifton · 2017-12-22T16:34:28Z

app/common/lib/historyUtil.js

+    return Immutable.List()
+  }
+
+  sites = makeImmutable(sites) ? makeImmutable(sites).toList() : Immutable.List()


I know this logic is the same as before, but I think it's wrong. Should it be:
sites = sites ? makeImmutable(sites).toList() : Immutable.List()

(makeImmutable won't return falsey values basically)

Since the above is checking == null (which should also return true for undefined, right?), I think we can simply make it
sites = makeImmutable(sites).toList()

Resolves brave#10296 Resolves brave#12378 Auditors: Test Plan:

bsclifton · 2017-12-22T16:51:22Z

app/common/lib/historyUtil.js

+
+  sites = makeImmutable(sites)
+
+  if (!isList(sites)) {


bsclifton

++ Looks great!

cezaraugusto

++

Follow up for sites splits PR #10296

cezaraugusto · 2017-12-22T17:17:13Z

master ea04284
0.21.x 387fe00
0.20.x d8712bc

NejcZdovc added the refactoring label Aug 6, 2017

NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Aug 6, 2017

NejcZdovc self-assigned this Aug 6, 2017

NejcZdovc added the PR/work-in-progress ⚒ label Aug 6, 2017

NejcZdovc force-pushed the refactor/split-sites-2 branch 3 times, most recently from eda3726 to 4bb21ee Compare August 9, 2017 11:02

NejcZdovc mentioned this pull request Aug 15, 2017

Moves bookmark text calculation into the state #10325

Merged

8 tasks

NejcZdovc added the PR/blocked label Aug 20, 2017

NejcZdovc force-pushed the refactor/split-sites-2 branch from 4bb21ee to 0cd4d5c Compare August 20, 2017 18:17

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this pull request Aug 20, 2017

Follow up for sites splits PR brave#10296

0cd4d5c

Resolves brave#10296 Resolves brave#10348 Resolves brave#10310 Auditors: Test Plan:

NejcZdovc force-pushed the refactor/split-sites-2 branch from 0cd4d5c to 8bdd858 Compare August 20, 2017 18:18

This was referenced Sep 6, 2017

Fixes bookmark move location cache #10819

Merged

Fixes removal of bookmarkLocation cache when removing bookmark folder #10909

Merged

ghost added the sprint/1 label Sep 13, 2017

NejcZdovc mentioned this pull request Sep 27, 2017

Manually apply changes from siteCache Enhancement PR to master #11174

Merged

8 tasks

luixxiul removed the PR/blocked label Sep 28, 2017

bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017

bbondy added release/blocking initiative/perf and removed sprint/1 labels Oct 27, 2017

cezaraugusto closed this Oct 28, 2017

NejcZdovc reopened this Oct 28, 2017

luixxiul added QA/test-plan-required release/blocking and removed release/blocking labels Oct 28, 2017

NejcZdovc mentioned this pull request Nov 7, 2017

Bookmarked icon keeps displayed after the bookmark is deleted #10348

Closed

NejcZdovc force-pushed the refactor/split-sites-2 branch from 8bdd858 to f1a68a8 Compare November 7, 2017 19:26

NejcZdovc force-pushed the refactor/split-sites-2 branch from f1a68a8 to f21ef48 Compare November 24, 2017 12:23

NejcZdovc removed the PR/work-in-progress ⚒ label Dec 22, 2017

NejcZdovc requested a review from bsclifton December 22, 2017 09:51

NejcZdovc removed the release/blocking label Dec 22, 2017

NejcZdovc requested review from petemill and cezaraugusto December 22, 2017 10:18

NejcZdovc force-pushed the refactor/split-sites-2 branch 3 times, most recently from 840342a to 1ff4d20 Compare December 22, 2017 13:05

NejcZdovc added QA/no-qa-needed release-notes/exclude and removed QA/test-plan-required labels Dec 22, 2017

NejcZdovc force-pushed the refactor/split-sites-2 branch from 1ff4d20 to 6aa99fb Compare December 22, 2017 15:55

bsclifton reviewed Dec 22, 2017

View reviewed changes

NejcZdovc force-pushed the refactor/split-sites-2 branch from 6aa99fb to ae7b30b Compare December 22, 2017 16:47

Follow up for sites splits PR brave#10296

b112310

Resolves brave#10296 Resolves brave#12378 Auditors: Test Plan:

NejcZdovc force-pushed the refactor/split-sites-2 branch from ae7b30b to b112310 Compare December 22, 2017 16:49

bsclifton reviewed Dec 22, 2017

View reviewed changes

app/common/lib/historyUtil.js

sites = makeImmutable(sites)

if (!isList(sites)) {

Copy link

Member

bsclifton Dec 22, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 👌

bsclifton approved these changes Dec 22, 2017

View reviewed changes

cezaraugusto approved these changes Dec 22, 2017

View reviewed changes

cezaraugusto merged commit ea04284 into brave:master Dec 22, 2017

cezaraugusto added a commit that referenced this pull request Dec 22, 2017

Merge pull request #10310 from NejcZdovc/refactor/split-sites-2

387fe00

Follow up for sites splits PR #10296

cezaraugusto added a commit that referenced this pull request Dec 22, 2017

Merge pull request #10310 from NejcZdovc/refactor/split-sites-2

d8712bc

Follow up for sites splits PR #10296

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Follow up for sites splits PR #10296 #10310

Follow up for sites splits PR #10296 #10310

NejcZdovc commented Aug 6, 2017 •

edited

Loading

NejcZdovc commented Aug 20, 2017 •

edited by luixxiul

Loading

cezaraugusto commented Oct 28, 2017

bsclifton Dec 22, 2017

bsclifton Dec 22, 2017

bsclifton Dec 22, 2017

NejcZdovc Dec 22, 2017

bsclifton Dec 22, 2017

bsclifton left a comment

cezaraugusto left a comment

cezaraugusto commented Dec 22, 2017

Follow up for sites splits PR #10296 #10310

Follow up for sites splits PR #10296 #10310

Conversation

NejcZdovc commented Aug 6, 2017 • edited Loading

NejcZdovc commented Aug 20, 2017 • edited by luixxiul Loading

cezaraugusto commented Oct 28, 2017

bsclifton Dec 22, 2017

Choose a reason for hiding this comment

bsclifton Dec 22, 2017

Choose a reason for hiding this comment

bsclifton Dec 22, 2017

Choose a reason for hiding this comment

NejcZdovc Dec 22, 2017

Choose a reason for hiding this comment

bsclifton Dec 22, 2017

Choose a reason for hiding this comment

bsclifton left a comment

Choose a reason for hiding this comment

cezaraugusto left a comment

Choose a reason for hiding this comment

cezaraugusto commented Dec 22, 2017

NejcZdovc commented Aug 6, 2017 •

edited

Loading

NejcZdovc commented Aug 20, 2017 •

edited by luixxiul

Loading