Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixes removal of bookmarkLocation cache when removing bookmark folder #10909

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 12, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Resolves #10908

Auditors:

Test Plan:

  • import bookmark file 300 from qa repo
  • delete folder 100-199
  • check that state was cleaned correctly (state->cache->bookmarkLocation should only have 99 items inside)

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Sep 12, 2017
@NejcZdovc NejcZdovc self-assigned this Sep 12, 2017
@NejcZdovc
Copy link
Contributor Author

unit tests will be added in #10310

@codecov-io
Copy link

codecov-io commented Sep 12, 2017

Codecov Report

Merging #10909 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10909      +/-   ##
==========================================
- Coverage   54.14%   54.14%   -0.01%     
==========================================
  Files         248      248              
  Lines       21750    21751       +1     
  Branches     3383     3383              
==========================================
  Hits        11777    11777              
- Misses       9973     9974       +1
Flag Coverage Δ
#unittest 54.14% <0%> (-0.01%) ⬇️
Impacted Files Coverage Δ
app/common/state/bookmarksState.js 76.33% <0%> (-0.35%) ⬇️

Copy link
Contributor

@ayumi ayumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works!

@NejcZdovc NejcZdovc merged commit 3da1304 into brave:master Sep 12, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants