Fixes bookmark move location cache

[NejcZdovc]

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.

Resolves #7032

Auditors:

Test Plan: specified in #7032 (comment)

Reviewer Checklist:

Tests

• Adequate test coverage exists to prevent regressions
• Tests should be independent and work correctly when run individually or as a suite ref
• New files have MPL2 license header

[NejcZdovc]

unit tests will be added in #10310

[codecov-io]

Codecov Report

Merging #10819 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #10819      +/-   ##
==========================================
- Coverage   54.17%   54.15%   -0.02%     
==========================================
  Files         247      247              
  Lines       21548    21553       +5     
  Branches     3338     3338              
==========================================
  Hits        11673    11673              
- Misses       9875     9880       +5

Flag	Coverage Δ
#unittest	54.15% <0%> (-0.02%)	⬇️

Impacted Files	Coverage Δ
app/common/state/bookmarksState.js	75% <0%> (-1.69%)	⬇️

[ayumi]

I'm not sure how to repro the original problem, but I think the code looks good.

[luixxiul]

@ayumi please see: #7032 (comment)

[ayumi]

@luixxiul the test plan seems to work on OSX on master?

STR is kind of confusing. First there are these two steps:

Make sure folder is selected as bookmark toolbar, instead of the new folder in which you put it

Bookmark toolbar remains location rather than the folder name

The steps don't seem to agree with: "Actual result: Root folder name is displayed, even if the bookmark exists under nested folder" because during STR the bookmark was specified as "bookmark toolbar".

I tried:
A) "Bookmark to top level / toolbar, create folder, move bookmark to folder, import"
B) "Create folder, bookmark and change dialog folder to folder, import"

Both seemed okay.

[luixxiul]

CC @srirambv

[cezaraugusto]

++

[srirambv]

Worked fine on Windows