Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

marketwatch.com - Ad slot "loading" icon #11730

Closed
lukemulks opened this issue Oct 31, 2017 · 4 comments
Closed

marketwatch.com - Ad slot "loading" icon #11730

lukemulks opened this issue Oct 31, 2017 · 4 comments

Comments

@lukemulks
Copy link
Collaborator

Description

https://www.marketwatch.com/ displays loading icons in the ad slots that do not stop spinning.

brave-marketwatch-10312017

Steps to Reproduce

  1. go to https://www.marketwatch.com/
  2. see ad slots with spinning icons
  3. fight hypnosis.

Actual result:
See above
Expected result:
No spinning icons.
Reproduces how often: [What percentage of the time does it reproduce?]
100%

Brave Version

Brave | 0.19.70
rev | d4b94c6

Reproducible on current live release:
Yes

Additional Information

@lukemulks lukemulks self-assigned this Oct 31, 2017
@kjozwiak
Copy link
Member

This doesn't appear to be a new regression, looks it was happening under Brave v0.19.53 rev: e09025b as well. Was double checking to ensure that it wasn't introduced in 0.19.70.

@lukemulks lukemulks removed their assignment Oct 31, 2017
@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 31, 2017

Looks like it's just an animated pseudo element. We could hide them with our own injected stylesheet. In fact, removeEmptyElements.css might be a good home for this.

marketwatch-loading

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, 0.22.x Release 2 (Beta Channel) Apr 5, 2018
@bsclifton bsclifton modified the milestones: 0.22.x Release 2 (Beta Channel), 0.22.x Release 3 Apr 6, 2018
@btlechowski
Copy link
Contributor

btlechowski commented Apr 11, 2018

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.109 5e4846e
  • libchromiumcontent: 65.0.3325.181
  • muon: 6.0.3

Verified on Mint 18.3 x64 using the following build:

  • 0.22.702 e4a853d
  • Muon: 6.0.7
  • libchromiumcontent: 66.0.3359.139

Verified on Windows x64

  • 0.22.702 e4a853d
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.7

@kjozwiak
Copy link
Member

kjozwiak commented May 3, 2018

@GeetaSarvadnya can you recheck this on Win?

@kjozwiak i have checked this issue on Windows 64 bit machine. Seems issue is fixed now. But these is one spinning icon shows on the screen for loading the graph. Graph should be shown immediately when the page loads but its taking few seconds extra after loading the page.
11730

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.