This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansampson
force-pushed
the
issue-11730
branch
from
March 21, 2018 02:52
acb377d
to
054037a
Compare
Codecov Report
@@ Coverage Diff @@
## master #13540 +/- ##
==========================================
- Coverage 56.78% 56.6% -0.18%
==========================================
Files 285 284 -1
Lines 29038 28675 -363
Branches 4803 4744 -59
==========================================
- Hits 16488 16231 -257
+ Misses 12550 12444 -106
|
bsclifton
approved these changes
Apr 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! 😄 👍
@bsclifton looks like this regressed; please confirm if OK to re-open |
@mandar-brave this was not shipped yet, it's targeted for single webview release |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
Resolves #11730
git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: