Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Updates on Beta channel are not working #11795

Closed
jamesray1 opened this issue Nov 5, 2017 · 11 comments
Closed

Updates on Beta channel are not working #11795

jamesray1 opened this issue Nov 5, 2017 · 11 comments
Assignees
@aekeus @bsclifton
Labels
infrastructure installation priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Milestone
0.20.x (Release C...

Comments

@jamesray1
Copy link

jamesray1 commented Nov 5, 2017 •
edited by bsclifton
Loading

Test plan

  1. Install an old beta version (ex: 0.20.14)
  2. Launch Brave-Beta and check for updates
  3. Confirm an update shows
  4. Update/relaunch and confirm you're using latest beta build

Description

Check for updates, get a message beginning with "Oops! We were not able to update."

updateLog.log

Reproduces how often:
100%

Brave Version

Brave: 0.19.58
rev: fe749c5
Muon: 4.5.4
libchromiumcontent: 62.0.3202.38
V8: 6.2.414.23
Node.js: 7.9.0
Update Channel: Beta
OS Platform: Microsoft Windows
OS Release: 10.0.15063
OS Architecture: x64

Reproducible on current live release:
Not sure.

Additional Information

Brave also keeps crashing randomly without any apparent cause.
@jamesray1
Copy link
Author

I went to brave.com and installed Brave, and now I have Brave 0.19.7, but the tab got frozen on that, so I think I'll need to use another browser.

@bsclifton
Copy link
Member

@jamesray1 0.19.58 is a beta release and it may not have been a proper release either. Can you please download a stable channel release?
https://github.com/brave/browser-laptop/releases/tag/v0.19.80dev

@bsclifton
Copy link
Member

bsclifton commented Nov 6, 2017 •
edited
Loading

OK I did verify that 0.19.58 was an actual Beta release- this can be seen here:
https://github.com/brave/vault-updater/blob/caf263b43ac469ba6b27352387ef39a32c1a34b3/data/beta/winx64.json#L24-L28

@aekeus any ideas on why the update would fail?

@bsclifton bsclifton reopened this Nov 6, 2017
@jamesray1
Copy link
Author

jamesray1 commented Nov 7, 2017 •
edited
Loading

If I ran the install from brave.com, shouldn't this install the latest stable release? When I ran the install it installed 0.19.7. I'll try that again tomorrow as I may have used an older installation file with the same filename. If it doesn't install the latest release (0.19.80) I'll try downloading and installing that. Also it appears that Brave on Linux has updated automatically to 0.19.80, which is good.

@bsclifton
Copy link
Member

@jamesray1 I just tried right now with Windows and the download link on Brave.com is for 0.19.80, as expected. Are you running a cache/proxy at your house (like squid?)

The link on Brave.com is to:
https://laptop-updates.brave.com/latest/winx64

@bsclifton
Copy link
Member

bsclifton commented Nov 7, 2017 •
edited
Loading

Regarding 0.19.58 (Beta) not able to upgrade, there is an actual issue with our beta releases at the moment. The binaries were not properly uploaded to S3. I'll be investigating this issue

@bsclifton bsclifton assigned bsclifton and unassigned aekeus Nov 7, 2017
@bsclifton bsclifton changed the title Check for updates failed Windows Updates on Beta channel are not working Nov 7, 2017
@jamesray1
Copy link
Author

I downloaded and installed Brave 0.19.80 for Windows from brave.com. As I suspected I think I must have used an installation file that I downloaded from before.

bsclifton added a commit to brave/release-tools that referenced this issue Nov 7, 2017
@bsclifton
Update the uploadBrowser to take channel-specific binary naming into …
6760243 
…account

Fixes brave/browser-laptop#11795

Auditors: @aekeus, @darkdh
@bsclifton bsclifton mentioned this issue Nov 7, 2017
Merged
This was referenced Nov 8, 2017
Closed
Closed
Closed
Closed
@bsclifton bsclifton reopened this Nov 17, 2017
@bsclifton
Copy link
Member

bsclifton commented Nov 17, 2017 •
edited
Loading

Not actually fixed (yet)

The uploads done via Jenkins were fixed correctly with brave/release-tools#2, but the service isn't taking Beta- in the filename into account. We'll need to update the server side on that one.

@aekeus can you help me look at this one? 😄

@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 4 (Release channel), 0.20.x (Beta Channel) Nov 17, 2017
@jamesray1
Copy link
Author

jamesray1 commented Nov 17, 2017 •
edited
Loading

OK, keep up the good work, the browser keeps getting better and better! I love the open-source approach. It'll be great to try out the BAT. Indeed I see that it's available, so I'll try it out.

bsclifton added a commit to brave/release-tools that referenced this issue Nov 20, 2017
@bsclifton
Add multi-channel support to updateBrowser.js. Pull common code int…
74ee8ea 
…o `common.js`

Fixes brave/browser-laptop#11795

Auditors: @aekeus
@bsclifton bsclifton mentioned this issue Nov 20, 2017
Merged
@alexwykoff alexwykoff added priority/P3 Major loss of function. release/blocking labels Nov 29, 2017
@LaurenWags LaurenWags mentioned this issue Dec 12, 2017
Closed
@bsclifton
Copy link
Member

@aekeus when you're back from holiday, can you help me with this one? 😄

This was referenced Jan 24, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

image

@srirambv srirambv mentioned this issue Jan 29, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Jan 29, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aekeus aekeus

@bsclifton bsclifton

Labels
infrastructure installation priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release/blocking release-notes/exclude
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
7 participants
@aekeus @alexwykoff @luixxiul @bsclifton @jamesray1 @srirambv @LaurenWags