Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Stop recreating shortcut on my desktop after every update #1181

Closed
Tarabass opened this issue Mar 26, 2016 · 20 comments
Closed

Stop recreating shortcut on my desktop after every update #1181

Tarabass opened this issue Mar 26, 2016 · 20 comments
Assignees
@aekeus
Labels
installation OS/Windows QA/test-plan-specified suggestion
Milestone
0.12.4dev

Comments

@Tarabass
Copy link

Every time Brave has an update the shortcut to Brave returns on my desktop. Maybe Brave should check, not with clean install though, that if the shortcut to Brave doesn't exist it should not be created?

I like to keep my Windows desktop nice and clean.
@Tarabass Tarabass changed the title New shortcut on my desktop after every update Recreated shortcut on my desktop after every update Mar 28, 2016
@luixxiul luixxiul changed the title Recreated shortcut on my desktop after every update Stop recreating shortcut on my desktop after every update May 21, 2016
@echosa
Copy link
Contributor

echosa commented Aug 12, 2016

Agreed. Having the desktop shortcut recreate itself every time is quite annoying. It's certainly not the most pressing of issues, but it will be greatly appreciated when fixed.

@bbondy bbondy added this to the 0.12.2dev milestone Sep 10, 2016
@bbondy
Copy link
Member

bbondy commented Sep 10, 2016

https://github.com/mongodb-js/electron-squirrel-startup/blob/master/index.js#L21

@bbondy
Copy link
Member

bbondy commented Sep 10, 2016

https://github.com/brave/browser-laptop/blob/master/app/windowsInit.js#L40

@bbondy bbondy self-assigned this Sep 10, 2016
@bbondy bbondy assigned aekeus and unassigned bbondy Sep 17, 2016
@aekeus
Copy link
Member

aekeus commented Sep 18, 2016 •
edited
Loading

Issue seems to be false static value (third) sent to function that controls the shortcut building:

https://github.com/Squirrel/Squirrel.Windows/blob/ee32fb469fc1ace0af6aef7edc389e27b8c063bb/src/Update/Program.cs#L464

https://github.com/Squirrel/Squirrel.Windows/blob/cedf4c296c830fcea09ff4ffca7cc1083b4ede67/src/Squirrel/UpdateManager.ApplyReleases.cs#L217

The command line does not take this as a parameter.

@aekeus
Copy link
Member

aekeus commented Sep 18, 2016

Issue created in Squirrel.Windows

Squirrel/Squirrel.Windows#831

@aekeus aekeus modified the milestones: 0.12.3dev, 0.12.2dev Sep 18, 2016
aekeus added a commit that referenced this issue Sep 20, 2016
@aekeus
Use custom versions of electron-squirrel-startup and electron-winstaller
a18d5c4 
  * Use forked version of two Windows installation modules
  * Do not re-create shortcuts on the desktop on auto-update

Auditors: @bbondy, @alexwykoff

Test plan:

  This change can only be tested via an auto-update

  Scenario 1

  i)   Install older version of browser
  ii)  Remove shortcut from desktop
  iii) Do an auto-update
  iV)  Ensure the shortcut was not created

  Scenario 2

  i)   Install older version of browser
  ii)  Do NOT remove shortcut from desktop
  iii) Do an auto-update
  iv)  Ensure the shortcut opens the most recent version of the browser

Fixes: #1181
@aekeus aekeus mentioned this issue Sep 20, 2016
Merged
@bbondy bbondy modified the milestones: 0.12.2dev, 0.12.3dev Sep 21, 2016
This was referenced Sep 22, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@aekeus
Copy link
Member

aekeus commented Sep 23, 2016

This is only testable via an auto-update on Windows. Will need to defer testing until binary up on updater dyno.

@aekeus
Copy link
Member

aekeus commented Sep 23, 2016

Re-opened for more testing

@bbondy bbondy modified the milestones: 0.12.4dev, 0.12.3dev Sep 30, 2016
bbondy pushed a commit that referenced this issue Sep 30, 2016
@aekeus @bbondy
Backout Squirrel modules to support update / insert of Windows shortcuts
0f8529d 
related to issue #1181

Auditors: @bbondy

Test Plan:

  Installation on Windows should operate as in previous versions.
  Both updates and installs will update existing shortcuts
  and re-create shortcuts if they do not exist.
@bbondy
Copy link
Member

bbondy commented Oct 4, 2016

would like to get this in after preview-1 @aekeus

This was referenced Oct 4, 2016
Closed
Closed
Closed
Closed
This was referenced Oct 5, 2016
Closed
Closed
Closed
Closed
aekeus added a commit that referenced this issue Oct 6, 2016
@aekeus
Do not re-create shortcuts on desktop after upgrading on Windows
78978c1 
Auditors: @bbondy

Test Plan:

  Located in #1181
@aekeus aekeus mentioned this issue Oct 6, 2016
Merged
@bbondy bbondy closed this as completed Oct 6, 2016
This was referenced Oct 6, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
bbondy added a commit that referenced this issue Sep 27, 2017
@bbondy
Tweak tests for #1181
b43cc79
bbondy added a commit that referenced this issue Sep 27, 2017
@bbondy
Tweak tests for #1181
d4154e2
bbondy added a commit that referenced this issue Sep 27, 2017
@bbondy
Tweak tests for #1181
1636e26
bbondy added a commit that referenced this issue Sep 27, 2017
@bbondy
Tweak tests for #1181
3597b81
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bbondy @syuan100
Tweak tests for brave#1181
0b69b8d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aekeus aekeus

Labels
installation OS/Windows QA/test-plan-specified suggestion
Projects
None yet
Milestone
0.12.4dev
Development

No branches or pull requests
8 participants
@echosa @aekeus @Tarabass @bbondy @alexwykoff @luixxiul @bsclifton @srirambv