Skip to content
This repository was archived by the owner on Dec 11, 2019. It is now read-only.

spellcheck setting is too tied to languages option #11811

Closed
cezaraugusto opened this issue Nov 6, 2017 · 0 comments · Fixed by #11812
Closed

spellcheck setting is too tied to languages option #11811

cezaraugusto opened this issue Nov 6, 2017 · 0 comments · Fixed by #11812
Assignees
@cezaraugusto
Labels
feature/spell-check priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@cezaraugusto
Copy link
Contributor

per feedback in #2183 (comment) this leads to confusion and can potentially lead to bad UX and less usage.

Setting to 0.19.x to match feature introduction
@cezaraugusto cezaraugusto self-assigned this Nov 6, 2017
cezaraugusto added a commit that referenced this issue Nov 6, 2017
@cezaraugusto
standout in prefs the spellcheck feature
0faa398 
fix #11811
-
this makes spellcheck a standalone list in the UI to avoid bad UX
Auditors: @darkdh
@cezaraugusto cezaraugusto mentioned this issue Nov 6, 2017
Merged
cezaraugusto added a commit that referenced this issue Nov 6, 2017
@cezaraugusto
standout in prefs the spellcheck feature
ecfcaad 
fix #11811
-
this makes spellcheck a standalone list in the UI to avoid bad UX
Auditors: @darkdh
@cezaraugusto cezaraugusto mentioned this issue Nov 6, 2017
Closed
cezaraugusto added a commit that referenced this issue Nov 6, 2017
@cezaraugusto
standout in prefs the spellcheck feature
6c862cd 
fix #11811
-
this makes spellcheck a standalone list in the UI to avoid bad UX
also moves spellcheck under advanced tab per Brad request
Auditors: @darkdh
@cezaraugusto cezaraugusto added the priority/P2 Crashes. Loss of data. Severe memory leak. label Nov 7, 2017
@cezaraugusto cezaraugusto modified the milestones: 0.19.x Hotfix 4 (Release channel), Prioritized Backlog, 0.20.x (Beta Channel) Nov 7, 2017
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@cezaraugusto @syuan100
standout in prefs the spellcheck feature
78fd0ba 
fix brave#11811
-
this makes spellcheck a standalone list in the UI to avoid bad UX
also moves spellcheck under advanced tab per Brad request
Auditors: @darkdh
@srirambv srirambv mentioned this issue Dec 20, 2017
Closed
27 tasks
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
feature/spell-check priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

move spellcheck and language settings under advanced panel brave/browser-laptop
6 participants
@luixxiul @cezaraugusto @bsclifton @NejcZdovc @srirambv @LaurenWags