Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Middle click on pinned tab causes other tabs to get pinned and loses the original pinned tab #11825

Closed
srirambv opened this issue Nov 7, 2017 · 5 comments · Fixed by #12413
Closed

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 7, 2017

Test plan

  1. Open a bunch of tabs and pin a few
  2. Middle click on a pinned tab to close
  3. Ensure other tabs are not affected by this

Description

Middle click on pinned tab causes other tabs to get pinned and looses the original pinned tab

Steps to Reproduce

  1. Clean install 0.20.6
  2. Open 4-5 tabs and visit sites in each of them
  3. Pin one of the tabs
  4. Middle click on the pinned tab, all other tabs get pinned momentarily and the original pinned tab is lost
    5. Relaunch browser, pinned tab is lost permanently

Actual result:
pintab

Expected result:
Should not do anything to pinned tabs or other open tabs

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.20.6
V8 6.2.414.36
rev 18f7d1e
Muon 4.5.14
OS Release 10.0.15063
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 62.0.3202.75

Reproducible on current live release:
N/A

Additional Information

@srirambv srirambv added this to the 0.20.x (Beta Channel) milestone Nov 7, 2017
@cezaraugusto cezaraugusto self-assigned this Nov 20, 2017
@alexwykoff alexwykoff added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Nov 29, 2017
@alexwykoff
Copy link
Contributor

@srirambv could you give this another go? Thanks!

@alexwykoff alexwykoff changed the title Middle click on pinned tab causes other tabs to get pinned and looses the original pinned tab Middle click on pinned tab causes other tabs to get pinned and loses the original pinned tab Nov 29, 2017
@petemill
Copy link
Member

Just reproduced on master

@srirambv
Copy link
Collaborator Author

Side effect of this issue is captured here #12379

@cezaraugusto
Copy link
Contributor

bug confirmed but btw closing the pinned tab with middle click is the expected behavior

@petemill
Copy link
Member

surely if middle-click to close should work, then cmd(or ctrl)-w should also, since they do the same thing? It must be both or neither, I would imagine, since they are the same 'shortcut'.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.