This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Pinning tabs with multiple windows open results in duplicates #11861
Labels
bug
feature/pinned-tabs
priority/P2
Crashes. Loss of data. Severe memory leak.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
regression
release-notes/exclude
Milestone
Description
Pinning tabs often causes those tabs to be pinned multiple times, especially if there is more than 1 window open. This is likely because
updatePinnedTabs
fires cyclically, i.e:1. A tab is pinned in windowA
2. updatePinnedTabs is called to ensure all other windows get the pinned tabs
3. windowB has the tab pinned, which causes…
4. updatePinnedTabs to be called
5. State is not necessarily up to date, so windowB or windowC gets the tab pinned again
Steps to Reproduce
This can then cause some weird errors when a window's tab state is out of sync with what it should have.
Actual result:
Expected result:
Reproduces how often:
Brave Version
about:brave info:
master (0.22)
Reproducible on current live release:
No
The text was updated successfully, but these errors were encountered: