Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Make BAT matching promotion configurable #11869

Closed
bsclifton opened this issue Nov 9, 2017 · 4 comments
Closed

Make BAT matching promotion configurable #11869

bsclifton opened this issue Nov 9, 2017 · 4 comments

Comments

@bsclifton
Copy link
Member

This is a sub-task of #11100

Description

The promotion should be able to be turned on or off (client side) via a single configuration value. This config setting would be checked by other issues, such as #11867 and #11868

When disabled

Promotional text will not be shown

When enabled

We can either:

  • make a call to the back end to see if the promotion is still in effect
    OR
  • show the promotion
@NejcZdovc
Copy link
Contributor

@bsclifton I think that all configuration will be done in libraries/server and browser will just read data. This way we don't need to deploy new version to turn promotion on/off

cc @mrose17

@mrose17
Copy link
Member

mrose17 commented Nov 9, 2017

@NejcZdovc - that is my belief as well. it is all data-driven! i hope to have the repos updated by COB us/pacific!

@bsclifton
Copy link
Member Author

@NejcZdovc totally agree- as long as the bat-client can handle offline scenarios (returning false for promotion enabled, for example)

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton
Copy link
Member Author

Fixed with #11874 - all info comes from server side

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants