Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add "trimming" to long URLs in Shields Panel blocked URLs #11899

Closed
bradleyrichter opened this issue Nov 10, 2017 · 3 comments
Closed

Add "trimming" to long URLs in Shields Panel blocked URLs #11899

bradleyrichter opened this issue Nov 10, 2017 · 3 comments
Assignees
Labels
0.20.x issue first seen in 0.20.x feature/shields polish Nice to have — usually related to front-end/visual tasks. QA/no-qa-needed release-notes/exclude

Comments

@bradleyrichter
Copy link
Contributor

This layout problem can be solved and simplified by trimming the extra path info past the first slash.

The link itself should remain linked and allow for rt-click menu access to "copy link".

image

Actual URL:

https://googleads.g.doubleclick.net/pagead/viewthroughconversion/1036322744/?value=0&label=AgenCNqg-QMQuI-U7gM&guid=ON&script=0&url=creditcards.chase.com%2Faudiences%2F62334757

Displayed URL:
https://googleads.g.doubleclick.net/

@bradleyrichter bradleyrichter added enhancement feature/shields polish Nice to have — usually related to front-end/visual tasks. labels Nov 10, 2017
@luixxiul
Copy link
Contributor

luixxiul commented Nov 11, 2017

this can be solved with #11880, which is same way as #9840 (comment) for the compact panel.

@luixxiul
Copy link
Contributor

luixxiul commented Nov 11, 2017

By fixing in the above way you would avoid having duplicate domains in the list. (Without that fix, you would also get the wide panel for a very long domain anyway. This issue should be fixed with 38cbbe3 of #11880.)

@luixxiul luixxiul added this to the 0.20.x (Beta Channel) milestone Nov 11, 2017
@luixxiul luixxiul added the 0.20.x issue first seen in 0.20.x label Nov 11, 2017
@luixxiul luixxiul self-assigned this Nov 11, 2017
@bradleyrichter
Copy link
Contributor Author

I don't mind duplicate domains if the full URL is available by hover and rt-click to copy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.20.x issue first seen in 0.20.x feature/shields polish Nice to have — usually related to front-end/visual tasks. QA/no-qa-needed release-notes/exclude
Projects
None yet
Development

No branches or pull requests

3 participants