Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix bravery panel width from increasing #9840

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Fix bravery panel width from increasing #9840

merged 1 commit into from
Jul 4, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jul 2, 2017 •
edited
Loading

Closes #9839
Addresses #9016

Auditors:

Test Plan:

  1. Open twitter.com
  2. Enable Block Scripts
  3. Click the counter
  4. Make sure the panel width does not increase

twitter

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

@luixxiul luixxiul added feature/shields polish Nice to have — usually related to front-end/visual tasks. labels Jul 2, 2017
@luixxiul luixxiul added this to the 0.20.x (Nightly Channel) milestone Jul 2, 2017
@luixxiul luixxiul self-assigned this Jul 2, 2017
luixxiul
luixxiul commented Jul 2, 2017
View reviewed changes
app/renderer/components/main/braveryPanel.js
margin: '0 0 .75rem 0',
wordBreak: 'break-all',
padding: '0 .5rem 1rem',
margin: '0 0 .25rem 0',
Copy link
Contributor Author

@luixxiul luixxiul Jul 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are set to make the list scrollable (y axis) to its bottom. I could not find out how to do the same thing for x axis. It still works though.

Fix bravery panel width from increasing
e185f62 
Closes #9839
Addresses #9016

Auditors:

Test Plan:
1. Open twitter.com
2. Enable `Block Scripts`
3. Click the counter
4. Make sure the panel width does not increase
cezaraugusto
cezaraugusto reviewed Jul 4, 2017
View reviewed changes
app/renderer/components/main/braveryPanel.js
// #9839: Avoid the panel width from increasing
width: 0,
whiteSpace: 'nowrap',

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow elegant fix

cezaraugusto
cezaraugusto approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit a2a7ddd into brave:master Jul 4, 2017
@luixxiul luixxiul mentioned this pull request Jul 4, 2017
Closed
@luixxiul luixxiul deleted the compactBraveryPanel-polish branch July 4, 2017 03:51
@luixxiul luixxiul mentioned this pull request Jul 24, 2017
Closed
5 tasks
@luixxiul luixxiul mentioned this pull request Nov 11, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees

@luixxiul luixxiul

Labels
feature/shields polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@luixxiul @cezaraugusto