Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Hyperlinks in about:brave always looks grey #12015

Closed
srirambv opened this issue Nov 17, 2017 · 4 comments · Fixed by #12687
Closed

Hyperlinks in about:brave always looks grey #12015

srirambv opened this issue Nov 17, 2017 · 4 comments · Fixed by #12687

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 17, 2017

Test plan

8110f82

Ensure the following appear as orange anchor links:

  1. Payment FAQ on about:preferences#payment
  2. Adobe and wiki about:preferences#plugins
  3. Release notes and revision on about:brave
  4. Inspect pages on about:extensions
  5. Community under about:preferences#extensions
  6. Manage passwords on about:preferences#security

Description

Hyperlinks in about:brave always looks grey

Steps to Reproduce

  1. Open about:brave
  2. Hyperlinks on the page looks greyed out
  3. Hover over doesn't change

Actual result:
hyperlink

Expected result:
Should be similar to the beta version

Reproduces how often:
100%

Brave Version

about:brave info:

Reproducible on current live release:

Additional Information

@luixxiul
Copy link
Contributor

This will be fixed with 8110f82#diff-83a9c31b7f8db399cce791535a519b5f. Closing and adding the milestone as the PR #10163 does not have the tracking issue for it.

@kjozwiak
Copy link
Member

Generally working well! However, hovering over the community link under about:preferences#extensions doesn't change as expected. Example:

communitylink

All links under about:preferences should behave the same. This should be a minor/quick fix. I've also ended the above Test Plan to include this case.

@kjozwiak kjozwiak reopened this Dec 21, 2017
@luixxiul
Copy link
Contributor

I'll take this one, thanks for checking.

@bsclifton bsclifton assigned luixxiul and unassigned evq Dec 22, 2017
@bsclifton
Copy link
Member

@luixxiul are you actively working this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.