Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Send week of installation and ref parameter to updater #12134

Closed
aekeus opened this issue Nov 29, 2017 · 6 comments
Closed

Send week of installation and ref parameter to updater #12134

aekeus opened this issue Nov 29, 2017 · 6 comments

Comments

@aekeus
Copy link
Member

aekeus commented Nov 29, 2017

Test plan

See #12135

Description

We need to send the date of the previous Monday of an installation, and a promotion ref identifier to the updater.

@aekeus aekeus added this to the Backlog (Prioritized) milestone Nov 29, 2017
@aekeus aekeus self-assigned this Nov 29, 2017
@bsclifton bsclifton modified the milestones: Backlog (Prioritized), 0.19.x Hotfix 7 (Release channel) Dec 1, 2017
@bsclifton
Copy link
Member

Fixed with #12135

@srirambv
Copy link
Collaborator

Fails on Windows when running test plan

Sriram BV@DESKTOP-97HVIA8 MINGW64 /e/srirambv/master/browser-laptop (0.19.x+C63|MERGING)
$ REF=promo1 CHANNEL=dev npm run build-package
npm ERR! file E:\srirambv\master\browser-laptop\package.json
npm ERR! code EJSONPARSE
npm ERR! Failed to parse json
npm ERR! Unexpected token '<' at 3:1
npm ERR! <<<<<<< HEAD
npm ERR! ^
npm ERR! File: E:\srirambv\master\browser-laptop\package.json
npm ERR! Failed to parse package.json data.
npm ERR! package.json must be actual JSON, not just JavaScript.
npm ERR!
npm ERR! This is not a bug in npm.
npm ERR! Tell the package author to fix their package.json file. JSON.parse

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\Sriram BV\AppData\Roaming\npm-cache\_logs\2017-12-11T09_29_49_224Z-debug.log

@bsclifton
Copy link
Member

Re-fixed with #12247

@srirambv
Copy link
Collaborator

image
image
Seeing this on Updatelog and session-store-1 file. for a clean install

@srirambv
Copy link
Collaborator

Works on Linux too
image
image

@LaurenWags
Copy link
Member

MacOS using packaged build 0.19.115:
screen shot 2017-12-12 at 4 23 26 pm

screen shot 2017-12-12 at 4 24 18 pm

@bsclifton bsclifton modified the milestones: 0.19.x + C63 (Release Channel), 0.19.x Private Search Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.