This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Send week of installation and ref parameter to updater #12135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsclifton
reviewed
Nov 29, 2017
test/unit/app/browser/datesTest.js
Outdated
|
|
||
| require('../../braveUnit') | ||
|
|
||
| describe('update date handling', function () { |
There was a problem hiding this comment.
awesome! Thanks for adding this 😄
Codecov Report
@@ Coverage Diff @@
## master #12135 +/- ##
==========================================
+ Coverage 54.96% 55% +0.03%
==========================================
Files 275 275
Lines 26549 26569 +20
Branches 4270 4273 +3
==========================================
+ Hits 14593 14613 +20
Misses 11956 11956
|
bsclifton
modified the milestones:
0.20.x (Beta Channel),
0.19.x Hotfix 7 (Release channel)
bsclifton
suggested changes
Dec 4, 2017
* On first installation store the date of the previous Monday in
session
* Accept ref parameter in build-package to store a promo
* identifier
* Send woi and ref parameters on update requests
Auditors: @clifton, @bbondy
Test Plan:
* Clear session file
* Build browser executable `REF=promo1 CHANNEL=dev npm run
* build-package`
* Open built binary
* Close browser
* Inspect session file
a) Ensure weekOfInstallation has date of previous Monday
* Open browser
* Check for an update
* Open updateLog.log
a) Ensure query has `woi` and `ref` parameters
bsclifton
force-pushed
the
woi-ref-params
branch
from
b5639b9 to
64a623e
Compare
bsclifton
reviewed
Dec 4, 2017
| const d = new Date(exampleDate) | ||
| assert.equal(dates.lastMonday(d), '2017-11-13', 'previous Monday') | ||
| }) | ||
| it('returns YYYY-MM-DD of today if today is monday', function () { |
There was a problem hiding this comment.
@aekeus here's the test I added regarding the previous comment
bsclifton
force-pushed
the
woi-ref-params
branch
from
64a623e to
18e45e7
Compare
bsclifton
approved these changes
Dec 4, 2017
bsclifton
added a commit
that referenced
this pull request
Dec 4, 2017
Send week of installation and ref parameter to updater
bsclifton
added a commit
that referenced
this pull request
Dec 4, 2017
Send week of installation and ref parameter to updater
bsclifton
added a commit
that referenced
this pull request
Dec 4, 2017
Send week of installation and ref parameter to updater
bsclifton
modified the milestones:
0.19.x Hotfix 7 (Release channel),
0.19.x + C63 (Release Channel)
bsclifton
modified the milestones:
0.19.x + C63 (Release Channel),
0.19.x Private Search
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
session
Auditors: @bsclifton, @bbondy
Test Plan:
REF=promo1 CHANNEL=dev npm run build-package--user-data-dir-name=brave-developmentflag so you don't overwrite your production profile)~/Library/Application Support/session-store-1)a) Ensure weekOfInstallation has date of previous Monday
b) Ensure promoCode has the value
promo1a) Ensure query has
woiandrefparametersImplements: #12134
Submitter Checklist:
git rebase -ito squash commits (if needed).Reviewer Checklist:
Tests