Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

displayed Brave wallet address and QR code do not have the same value after restoring wallet #12170

Closed
LaurenWags opened this issue Dec 4, 2017 · 5 comments

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 4, 2017

Test plan

  1. Create a BAT wallet (does not have to have funds). Save recovery file for this wallet.
  2. Set profile aside and create a clean profile.
  3. Enable payments, grab screenshots of wallet addresses and QR codes for currencies.
  4. restore wallet from step 1.
  5. Go to the Add Funds dialog and verify wallet addresses against QR codes.

Original issue description

Description

Sometimes the displayed Brave wallet address (for any currency: BTC, ETH, BAT, LTC) does not match the QR code value. I have only been able to reproduce this on a recovered wallet.

Reported via community: https://community.brave.com/t/alphanumeric-address-qr-code-address-when-i-add-funds/11613

Steps to Reproduce

  1. Create a BAT wallet (does not have to have funds). Save recovery file for this wallet.
  2. Set profile aside and create a clean profile.
  3. Enable payments, grab screenshots of wallet addresses and QR codes for currencies.
  4. restore wallet from step 1.
  5. Go to the Add Funds dialog and verify wallet addresses against QR codes. QR codes match step 3 but displayed wallet addresses are for the restored wallet.

Actual result:
When backup words are not displayed correctly because you restored your wallet, your QR code address does not match your displayed wallet address.
Ex: Displayed value is in image below. However, if you scan the QR code, you will get a different value of bitcoin:13JoDbYTG9RQZkuDUhtKHY8B7vHAUYa3Ni
screen shot 2017-12-04 at 5 02 20 pm

Expected result:
These should always match.

Reproduces how often:
easy

Brave Version

about:brave info:
Brave | 0.19.105
rev | 51f8ba5
Muon | 4.5.16

Reproducible on current live release:
Yes

Additional Information

@LaurenWags LaurenWags added 0.19.x issue first seen in 0.19.x bug feature/rewards initiative/bat-payments priority/P2 Crashes. Loss of data. Severe memory leak. labels Dec 4, 2017
@LaurenWags LaurenWags changed the title sometimes displayed Brave wallet address and QR code do not have the same value displayed Brave wallet address and QR code do not have the same value after restoring wallet Dec 4, 2017
@LaurenWags
Copy link
Member Author

Another way to reproduce this:
Have a wallet created.
Close Brave.
Delete your ledger* files and folders from ~/Library/Application Support/brave
Reopen Brave
New wallet is created.
QR code does not match displayed wallet address.

@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Dec 10, 2017
@NejcZdovc NejcZdovc self-assigned this Dec 15, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 16, 2017
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.19.x Hotfix 9 Dec 16, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Dec 18, 2017
@bsclifton bsclifton modified the milestones: 0.19.x Hotfix 9, 0.21.x (Developer Channel) Dec 20, 2017
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Jan 2, 2018
bsclifton added a commit that referenced this issue Jan 3, 2018
Fixes QR and addresses after wallet recovery
bsclifton added a commit that referenced this issue Jan 3, 2018
Fixes QR and addresses after wallet recovery
bsclifton added a commit that referenced this issue Jan 3, 2018
Fixes QR and addresses after wallet recovery
@srirambv
Copy link
Collaborator

srirambv commented Jan 9, 2018

Works fine on Windows

@LaurenWags
Copy link
Member Author

Reproduced on MacOS and Win by @srirambv using steps from #12170 (comment)

@LaurenWags LaurenWags reopened this Jan 9, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jan 10, 2018

@LaurenWags can we close this one and create another issue, because this issue is about recovery, where we reopen it because of the different scenario. Already looking into this second scenario.

@LaurenWags
Copy link
Member Author

Created #12592 and assigned you @NejcZdovc for issue described in #12170 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants