Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Blocked scripts are not counted #12178

Closed
luixxiul opened this issue Dec 5, 2017 · 1 comment
Closed

Blocked scripts are not counted #12178

luixxiul opened this issue Dec 5, 2017 · 1 comment
Assignees
@darkdh
Labels
0.19.x issue first seen in 0.19.x bug cr63 feature/shields feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.19.x Hotfix 8 (...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 5, 2017

Description

Blocked scripts are not counted. Also the noScript icon is not displayed on the URL bar.

Steps to Reproduce

  1. Open https://brianbondy.com/
  2. Toggle Block Scripts on the bravery panel

Actual result:

bug

Expected result:

  1. The number of the blocked scripts, which should be 3, should be displayed
  2. The noScript icon should be displayed on the URL bar

Reproduces how often:

Consistently

Brave Version

about:brave info:

Brave: 0.19.106
rev: 88cb988
Muon: 4.5.21
libchromiumcontent: 63.0.3239.59
V8: 6.3.292
Node.js: 7.9.0
Update Channel: Release
OS Platform: Linux
OS Release: 4.9.0-4-amd64
OS Architecture: x64

Reproducible on current live release:

Additional Information
@luixxiul luixxiul added this to the 0.19.x + C63 (Release Channel) milestone Dec 5, 2017
@darkdh darkdh self-assigned this Dec 6, 2017
darkdh added a commit to brave/muon that referenced this issue Dec 6, 2017
@darkdh
Handle ipc for OOPIFs missing changes
c307d77 
fix brave/browser-laptop#12178

Auditors: @bridiver
@darkdh
Copy link
Member

darkdh commented Dec 6, 2017

fixed by brave/muon@c307d77
muon 4.5.23

@darkdh darkdh closed this as completed Dec 6, 2017
This was referenced Dec 6, 2017
Closed
Closed
Closed
Closed
bridiver pushed a commit to brave/muon that referenced this issue Dec 6, 2017
@darkdh @bridiver
Handle ipc for OOPIFs missing changes
ed7a846 
fix brave/browser-laptop#12178

Auditors: @bridiver
This was referenced Dec 11, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
0.19.x issue first seen in 0.19.x bug cr63 feature/shields feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 8 (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @luixxiul @darkdh @srirambv @LaurenWags