Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

enable SSL certificate pinning for important Brave domains #12190

Closed
diracdeltas opened this issue Dec 5, 2017 · 4 comments
Closed

enable SSL certificate pinning for important Brave domains #12190

diracdeltas opened this issue Dec 5, 2017 · 4 comments

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Dec 5, 2017

Test plan

See #12190 (comment)

Original issue description

we should mitigate against TLS MITM attacks by using certificate pinning / expect-CT for important domains in browser-laptop (Brave update server, Brave extensions update server, ledger servers, etc.). this may be doable by simply adding to https://chromium.googlesource.com/chromium/src/net/+/master/http/transport_security_state_static.json

cc @jumde

@jumde jumde self-assigned this Dec 12, 2017
@diracdeltas diracdeltas changed the title enable SSL certificate pinning / expect-CT for important Brave domains enable SSL certificate pinning for important Brave domains Dec 19, 2017
@diracdeltas diracdeltas added this to the 0.21.x (Developer Channel) milestone Jan 3, 2018
@diracdeltas
Copy link
Member Author

This was done in brave/muon#401

@diracdeltas
Copy link
Member Author

diracdeltas commented Jan 17, 2018

Test plan:

  1. remove the browser profile folder
  2. open devtools and go to http://roundcube.mayfirst.org
  3. in the network requests devtools tab, you should see http://roundcube.mayfirst.org redirect to https with a 307 code

@LaurenWags
Copy link
Member

Works on MacOS:
screen shot 2018-01-18 at 1 08 19 pm

@kjozwiak
Copy link
Member

Same results as @LaurenWags under Win 10 x64 and Ubuntu 17.10 x64 using 0.19.13838f8509.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.