Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Formatting for contribution report should match payments screen #12217

Closed
bsclifton opened this issue Dec 7, 2017 · 1 comment
Closed

Formatting for contribution report should match payments screen #12217

bsclifton opened this issue Dec 7, 2017 · 1 comment
Assignees
@NejcZdovc
Labels
feature/rewards priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.20.x (Release C...

Comments

@bsclifton
Copy link
Member

bsclifton commented Dec 7, 2017 •
edited
Loading

Test plan

See #12769

Description

When pulling up a contribution report which has YouTube channels listed, the formatting doesn't match how the payments screen displays it

Steps to Reproduce

  1. Visit some YouTube sites, enough to get them added to payments
  2. Have a settlement happen
  3. View the contribution report

Actual result:
image

Expected result:
screen shot 2017-12-07 at 11 44 19 am

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.19.105
rev: 51f8ba5
Muon: 4.5.16
libchromiumcontent: 62.0.3202.94
V8: 6.2.414.42
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 17.3.0
OS Architecture: x64

Reproducible on current live release:

Yes

Additional Information
@bsclifton bsclifton added feature/rewards priority/P4 Minor loss of function. Workaround usually present. labels Dec 7, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Dec 7, 2017
@LaurenWags LaurenWags mentioned this issue Dec 13, 2017
Closed
@NejcZdovc NejcZdovc modified the milestones: Backlog (Prioritized), 0.20.x (Beta Channel) Jan 22, 2018
@NejcZdovc
Copy link
Contributor

Pulling into 0.20, because we have a regression, where verified check is not working correctly and will be fixed in this issues PR

@NejcZdovc NejcZdovc self-assigned this Jan 22, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 22, 2018
@NejcZdovc
Fixes contribution pdf when having media publishers in
cb96005 
Resolves brave#12217

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Jan 22, 2018
Merged
10 tasks
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 22, 2018
@NejcZdovc
Fixes contribution pdf when having media publishers in
83828df 
Resolves brave#12217

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 22, 2018
@NejcZdovc
Fixes contribution pdf when having media publishers in
45544b9 
Resolves brave#12217

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Jan 22, 2018
@bsclifton
Merge pull request #12769 from NejcZdovc/hotfix/#12217-contribution
f3db734 
Fixes contribution pdf when having media publishers in
bsclifton added a commit that referenced this issue Jan 22, 2018
@bsclifton
Merge pull request #12769 from NejcZdovc/hotfix/#12217-contribution
692f205 
Fixes contribution pdf when having media publishers in
bsclifton added a commit that referenced this issue Jan 22, 2018
@bsclifton
Merge pull request #12769 from NejcZdovc/hotfix/#12217-contribution
96f38ed 
Fixes contribution pdf when having media publishers in
This was referenced Jan 22, 2018
Closed
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

No branches or pull requests
5 participants
@kjozwiak @bsclifton @NejcZdovc @srirambv @LaurenWags