Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

When doing DuckDuckGo search from private tab, we should send "bravep" with query string instead of "brave" #12219

Closed
bsclifton opened this issue Dec 7, 2017 · 0 comments · Fixed by #12222
Closed

When doing DuckDuckGo search from private tab, we should send "bravep" with query string instead of "brave" #12219

bsclifton opened this issue Dec 7, 2017 · 0 comments · Fixed by #12222
Assignees
@petemill
Labels
feature/private-tabs initiative/private-search priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x Hotfix 7 (...

Comments

@bsclifton
Copy link
Member

bsclifton commented Dec 7, 2017 •
edited
Loading

Test plan

See #12222

Description

When doing a DuckDuckGo search from a private tab, we should be appending t=bravep to the query string. We currently append t=brave for all searches. You can see that here:

browser-laptop/js/data/searchProviders.js

Line 27 in 4a27814

"search" : "https://duckduckgo.com/?q={searchTerms}&t=brave",

Steps to Reproduce

  1. Set DuckDuckGo as your default search provider
  2. Open a new private tab
  3. In the URL bar, search for "brave software"

Actual result:

t=brave is added to the query string

Expected result:
t=bravep should be added to the query string

Reproduces how often:

100%

Brave Version

about:brave info:

Reproducible on current live release:

Yes

Additional Information
@bsclifton bsclifton added feature/private-tabs initiative/private-search priority/P2 Crashes. Loss of data. Severe memory leak. labels Dec 7, 2017
@bsclifton bsclifton added this to the 0.19.x + C63 (Release Channel) milestone Dec 7, 2017
petemill added a commit to petemill/browser-laptop that referenced this issue Dec 7, 2017
@petemill
Allow search provider to specify different search Url for private tabs
aacc788 
This 'privateSearch' Url will be used for all searches performed in a private tab, including if provider is default, is the Private Search provider, or is chosen due to a shortcut (e.g. ':d my search term').
Specify a different private search Url for DuckDuckGo.

Fix brave#12219
@petemill petemill mentioned this issue Dec 7, 2017
Merged
8 tasks
This was referenced Dec 8, 2017
Closed
Closed
Closed
This was referenced Dec 11, 2017
Closed
Closed
@srirambv srirambv mentioned this issue Dec 12, 2017
Closed
@bsclifton bsclifton modified the milestones: 0.19.x + C63 (Release Channel), 0.19.x Private Search Dec 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petemill petemill

Labels
feature/private-tabs initiative/private-search priority/P2 Crashes. Loss of data. Severe memory leak. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x Hotfix 7 (Release channel)
Development

Successfully merging a pull request may close this issue.

Allow search provider to specify different search Url for private tabs petemill/browser-laptop
5 participants
@petemill @luixxiul @bsclifton @srirambv @LaurenWags